BPF List
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Omokefe Emmanuel Onanaroghene" <emmaonana18@gmail.com>,
	bpf@vger.kernel.org
Subject: Re: [PATCH] selftests: net: veth: propagate channel-check failures to exit status
Date: Sun, 15 Nov 2026 21:24:35 +0000	[thread overview]
Message-ID: <sashiko-outbox-215866@kernel.org> (raw)
In-Reply-To: <20261115212117.48496-1-emmaonana18@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests: net: veth: wrong Fixes trailer for chk_channels() fix
--

commit f30572a6b8a908de83aa08afbd2a257c0b17b275
Author: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>

> selftests: net: veth: propagate channel-check failures to exit status
>
> chk_channels() reports mismatches with a "fail" line but never sets
> ret, so the script exits 0 even when channel counts are wrong. Every
> other check helper in the file (__chk_flag, chk_xdp_feature, chk_gro)
> sets ret=1 on failure, and all chk_channels() call sites expect the
> check to pass. Set ret=1 on mismatch.
>
> Fixes: c017800af5c71 ("selftests: net: veth: test peer ndo-xmit after GRO toggle while down")
> Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>

[Severity: Low]
Commit c017800af5c7 ("selftests: net: veth: test peer ndo-xmit after GRO
toggle while down") added chk_xdp_feature() above chk_channels() without
touching chk_channels().  chk_channels() and its failure branch omitting
ret=1 were introduced by commit 1ec2230fc721 ("selftests: net: veth: add
tests for set_channel"), so the Fixes tag should be:

  Fixes: 1ec2230fc721 ("selftests: net: veth: add tests for set_channel")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115212117.48496-1-emmaonana18@gmail.com?part=1

  reply	other threads:[~2026-11-15 21:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 21:21 [PATCH] selftests: net: veth: propagate channel-check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-15 21:24 ` sashiko-bot [this message]
2026-11-15 21:34 ` Tianyi Gao
2026-11-15 22:02   ` Omokefe Emmanuel Onanaroghene

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215866@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=emmaonana18@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox