From: sashiko-bot@kernel.org
To: "Ankur Arora" <ankur.a.arora@oracle.com>, bpf@vger.kernel.org
Subject: Re: [PATCH v17 01/16] asm-generic: barrier: Add smp_cond_load_relaxed_timeout()
Date: Mon, 16 Nov 2026 08:42:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-216555@kernel.org> (raw)
In-Reply-To: <20261116082437.66739-2-ankur.a.arora@oracle.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] asm-generic: barrier: VAL shadowing in
smp_cond_load_relaxed_timeout()
--
commit 02ca6bf44a71704c43817e6ae9df82d53740b4ff
Author: Ankur Arora <ankur.a.arora@oracle.com>
asm-generic: barrier: Add smp_cond_load_relaxed_timeout()
This commit adds smp_cond_load_relaxed_timeout() and its helper
__smp_cond_load_relaxed_timeout() to spin-wait on a condition with a
timeout using cpu_poll_relax().
> diff --git a/include/asm-generic/barrier.h b/include/asm-generic/barrier.h
> index b99cb57dfcccc..bafc8eeff1321 100644
> --- a/include/asm-generic/barrier.h
> +++ b/include/asm-generic/barrier.h
[ ... ]
> @@ -273,6 +274,117 @@ do { \
> })
> #endif
[ ... ]
> +#ifndef smp_cond_load_relaxed_timeout
> +#define __smp_cond_load_relaxed_timeout(ptr, cond_expr, \
> + time_expr_ns, timeout_ns, \
> + timed_out) \
> +({ \
> + typeof(ptr) __PTR = (ptr); \
> + __unqual_scalar_typeof(*(ptr)) VAL; \
[ ... ]
> +#define smp_cond_load_relaxed_timeout(ptr, cond_expr, \
> + time_expr_ns, timeout_ns) \
> +({ \
> + s64 __scl_timeout_ns = (s64)(timeout_ns); \
> + __unqual_scalar_typeof(*(ptr)) VAL; \
> + bool __maybe_unused __scl_timed_out = false; \
> + \
> + if (unlikely(__scl_timeout_ns < 0)) \
> + VAL = READ_ONCE(*(ptr)); \
> + else \
> + VAL = __smp_cond_load_relaxed_timeout(ptr, cond_expr, \
> + time_expr_ns, \
> + __scl_timeout_ns, \
> + __scl_timed_out); \
> + (typeof(*(ptr)))VAL; \
> +})
> +#endif
[Severity: Low]
Does naming the outer temporary VAL in smp_cond_load_relaxed_timeout()
cause -Wshadow warnings when __smp_cond_load_relaxed_timeout() declares
its own VAL in the nested statement expression?
Unlike smp_cond_load_acquire(), which names its outer variable _val,
reusing VAL here shadows the outer variable on every call (breaking W=2
builds with CONFIG_WERROR) and also declares VAL before evaluating ptr,
which would capture any caller variable named VAL referenced in ptr.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116082437.66739-1-ankur.a.arora@oracle.com?part=1
next prev parent reply other threads:[~2026-11-16 8:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 8:24 [PATCH v17 00/16] barrier: Add smp_cond_load_{relaxed,acquire}_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 01/16] asm-generic: barrier: Add smp_cond_load_relaxed_timeout() Ankur Arora
2026-11-16 8:42 ` sashiko-bot [this message]
2026-11-16 8:24 ` [PATCH v17 02/16] arm64: barrier: Support smp_cond_load_relaxed_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 03/16] arm64/delay: define arm64_wfet_deadline() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 04/16] arm64: support WFET in smp_cond_load_relaxed_timeout() Ankur Arora
2026-11-16 8:46 ` sashiko-bot
2026-11-16 8:24 ` [PATCH v17 05/16] arm64: rqspinlock: Remove private copy of smp_cond_load_acquire_timewait() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 06/16] asm-generic: barrier: Add smp_cond_load_acquire_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 07/16] atomic: Add atomic_cond_read_*_timeout() Ankur Arora
2026-11-16 8:49 ` sashiko-bot
2026-11-16 8:24 ` [PATCH v17 08/16] locking/atomic: scripts: build atomic_long_cond_read_*_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 09/16] bpf/rqspinlock: switch check_timeout() to a clock interface Ankur Arora
2026-11-16 8:24 ` [PATCH v17 10/16] bpf/rqspinlock: Use smp_cond_load_acquire_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 11/16] sched: add need-resched timed wait interface Ankur Arora
2026-11-16 8:24 ` [PATCH v17 12/16] cpuidle/poll_state: Wait for need-resched via tif_need_resched_relaxed_wait() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 13/16] arm64/delay: enable testing smp_cond_load_relaxed_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 14/16] barrier: add tests for smp_cond_load_*_timeout() Ankur Arora
2026-11-16 8:24 ` [PATCH v17 15/16] barrier: timeout validity checks for smp_cond_load_relaxed_timeout() Ankur Arora
2026-11-16 8:45 ` sashiko-bot
2026-11-16 8:24 ` [PATCH v17 16/16] barrier: timeout validity checks for smp_cond_load_acquire_timeout() Ankur Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216555@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ankur.a.arora@oracle.com \
--cc=bpf@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox