BPF List
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yun Lu" <luyun_611@163.com>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 6/6] selftests/bpf: Test wq callback setup after deletion and user release
Date: Thu, 19 Nov 2026 03:43:05 +0000	[thread overview]
Message-ID: <sashiko-outbox-222403@kernel.org> (raw)
In-Reply-To: <20261119033051.196177-7-luyun_611@163.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/bpf: multi-line comment style in
  test_wq_usercnt_reuse()
--

commit c499c2c6b9f5e1ec7aa72bc0571ecd4ff2c11fb1
Author: Yun Lu <luyun@kylinos.cn>

selftests/bpf: Test wq callback setup after deletion and user release

This commit adds BPF selftests covering bpf_wq_set_callback() on deleted
hash map elements and on reused elements after the last map user reference
is dropped.

> diff --git a/tools/testing/selftests/bpf/prog_tests/wq.c b/tools/testing/selftests/bpf/prog_tests/wq.c
> index a4f71bc34fa6c..f783a91417e00 100644
> --- a/tools/testing/selftests/bpf/prog_tests/wq.c
> +++ b/tools/testing/selftests/bpf/prog_tests/wq.c
> @@ -1,11 +1,109 @@

[ ... ]

> +/* Check callback setup after reusing an idle object with no map uref. */
> +static void test_wq_usercnt_reuse(void)
> +{

[ ... ]

> +		/* Drop all target-map user FDs; the retained program FD keeps
> +		 * the map alive through used_maps, but usercnt becomes zero.
> +		 */
> +		wq__destroy(skel);

[Severity: Low]
This isn't a bug, but BPF multi-line comment style puts the opening /* on
its own line with the comment text starting on the next line.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119033051.196177-1-luyun_611@163.com?part=6

  reply	other threads:[~2026-11-19  3:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  3:30 [PATCH bpf-next v4 0/6] bpf: Fix async callback use-after-free on map deletion Yun Lu
2026-11-19  3:30 ` [PATCH bpf-next v4 1/6] bpf: Mark task work FREED before detaching it Yun Lu
2026-11-19  3:30 ` [PATCH bpf-next v4 2/6] bpf: Check task work value membership before scheduling Yun Lu
2026-11-19  3:30 ` [PATCH bpf-next v4 3/6] selftests/bpf: Test task work scheduling on a deleted value Yun Lu
2026-11-19  3:30 ` [PATCH bpf-next v4 4/6] bpf: Invalidate async callbacks before detaching them Yun Lu
2026-11-19  3:30 ` [PATCH bpf-next v4 5/6] bpf: Check async callback membership and user references Yun Lu
2026-11-19  4:20   ` bot+bpf-ci
2026-11-19  3:30 ` [PATCH bpf-next v4 6/6] selftests/bpf: Test wq callback setup after deletion and user release Yun Lu
2026-11-19  3:43   ` sashiko-bot [this message]
2026-11-19  4:05   ` bot+bpf-ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222403@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=luyun_611@163.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox