BPF List
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Slawomir Stepien" <sst@poczta.fm>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH v7 bpf 2/5] xdp: introduce xdp_convert_skb_to_buff()
Date: Thu, 19 Nov 2026 13:41:28 +0000	[thread overview]
Message-ID: <sashiko-outbox-223190@kernel.org> (raw)
In-Reply-To: <20261119133032.2015656-3-sst@poczta.fm>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] xdp: malformed Signed-off-by trailers with trailing comments
--

commit b52c8a4a1dfa14f2b9eeae449bd2e813e860af3a
Author: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

xdp: introduce xdp_convert_skb_to_buff()

This commit factors out xdp_buff initialization from
bpf_prog_run_generic_xdp() into xdp_convert_skb_to_buff() and sets
MEM_TYPE_PAGE_POOL on the attached xdp_rxq_info so fragments released by
bpf_xdp_adjust_tail() are recycled properly.

[Severity: High]
In the commit message trailer block, the Signed-off-by trailers for
Octavian Purdila and Maciej Fijalkowski have trailing hash comments
appended after the closing angle bracket of the email address. Per
Documentation/process/submitting-patches.rst, Signed-off-by lines must end
at the closing > of the email address; any contributor attribution notes
should be moved into a separate bracketed [name: description] block.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119133032.2015656-1-sst@poczta.fm?part=2

  reply	other threads:[~2026-11-19 13:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:30 [PATCH v7 bpf 0/5] xdp: fix page_pool leaks Slawomir Stepien
2026-11-19 13:30 ` [PATCH v7 bpf 1/5] bpf: test_run: Use a private rxq info for XDP test runs Slawomir Stepien
2026-11-19 13:49   ` sashiko-bot
2026-11-19 13:30 ` [PATCH v7 bpf 2/5] xdp: introduce xdp_convert_skb_to_buff() Slawomir Stepien
2026-11-19 13:41   ` sashiko-bot [this message]
2026-11-19 13:30 ` [PATCH v7 bpf 3/5] veth: use the frame mem type when running XDP on an xdp_frame Slawomir Stepien
2026-11-19 13:54   ` bot+bpf-ci
2026-11-19 13:30 ` [PATCH v7 bpf 4/5] veth: update mem type in xdp_buff Slawomir Stepien
2026-11-19 13:30 ` [PATCH v7 bpf 5/5] selftests/bpf: Shrink test_run frags after generic XDP ran on lo Slawomir Stepien
2026-11-19 13:37   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223190@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sst@poczta.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox