BPF List
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 12/49] bpf: Keep more of what is known about a number
Date: Fri, 20 Nov 2026 08:18:09 +0000	[thread overview]
Message-ID: <sashiko-outbox-224702@kernel.org> (raw)
In-Reply-To: <20261120074430.2704488-13-alexei.starovoitov@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] bpf: scalar_intersect() zeroes upper 32 bits of var_off when
  bits is 32
--

commit cf38506673fee86eba3e381affed0c24f4518bbf
Author: Alexei Starovoitov <ast@kernel.org>

bpf: Keep more of what is known about a number

This commit refines six BPF verifier scalar transfer functions to preserve
more range, known-bit, parcial spill, and linear step information.

> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index de3e9675e509f..3229372c5f496 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c

[ ... ]

> @@ -3994,6 +3999,10 @@ static int check_stack_read_fixed_off(struct bpf_verifier_env *env,
>  				/* coerce_scalar_to_size will adjust the boundaries. */
>  				state->regs[dst_regno] = *reg;
>  			} else {
> +				/* the low bytes are from the spill */
> +				bool fill_exceeds_spill =
> +					size > spill_size && !(off % BPF_REG_SIZE) &&
> +					!IS_ENABLED(CONFIG_CPU_BIG_ENDIAN);
>  				int spill_cnt = 0, zero_cnt = 0;
>  
>  				for (i = 0; i < size; i++) {
> @@ -4033,6 +4042,10 @@ static int check_stack_read_fixed_off(struct bpf_verifier_env *env,
>  				} else {
>  					mark_reg_stack_read(env, reg_state, off, off + size,
>  							    dst_regno);
> +					if (fill_exceeds_spill)
> +						scalar_intersect(scalar_of(&state->regs[dst_regno]),
> +								 scalar_of(reg),
> +								 spill_size * BITS_PER_BYTE);
>  				}
>  			}
>  		} else if (dst_regno >= 0) {
[ ... ]
> @@ -18921,16 +18957,22 @@ bool scalar_intersect(struct scalar *dst, const struct scalar *src, u32 bits)
>  	/* tnum_intersect() of two tnums that don't overlap is not empty */
>  	if (!tnum_overlap(a, b))
>  		return false;
> +	s.var_off = tnum_intersect(a, b);
>  	/*
>  	 * Equal in 64 bits is equal in the low 32 bits too. 'if w1 s> 200' on a zero extended int
>  	 * refines nothing but the 32-bit range.
>  	 */
> -	s.r32 = cnum32_intersect(dst->r32, src->r32);
> +	if (bits >= 32)
> +		s.r32 = cnum32_intersect(dst->r32, src->r32);
>  	if (bits == 64) {
>  		s.r64 = cnum64_intersect(dst->r64, src->r64);
> -		s.var_off = tnum_intersect(a, b);
> -	} else {
> -		s.var_off = tnum_with_subreg(dst->var_off, tnum_intersect(a, b));
> +		if (src->step % dst->step == 0) {
> +			if (src->base % dst->step != dst->base)
> +				return false;
> +			s.step = src->step;
> +			s.base = src->base;
> +		}
> +		s.r64 = cnum64_intersect_linear(s.r64, s.base, s.step);
>  	}

[Severity: High]
Does dropping tnum_with_subreg() in scalar_intersect() falsely mark the
upper 32 bits of s.var_off as known zero when bits == 32?

When bits < 64, a and b are truncated with tnum_subreg(), which clears the
upper 32 bits of both value and mask to 0.  Assigning s.var_off =
tnum_intersect(a, b) directly then causes scalar_bounds_sync(&s) to clamp
s.r64 to a zero-extended 32-bit range.  For example, a 64-bit stack fill
overlapping a 32-bit scalar spill and 32 bits of STACK_MISC calls
scalar_intersect() with bits == 32 on an unknown 64-bit dst register,
leaving the verifier believing the upper 32 bits of dst are zero while at
runtime they hold arbitrary STACK_MISC data.  (A later commit in this
series, commit "bpf: Mark a state that no run of the program has",
reworks the bits < 64 handling in scalar_intersect() to preserve the upper
bits, so moving that change here would avoid this regression in
intermediate commits.)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120074430.2704488-1-alexei.starovoitov@gmail.com?part=12

  reply	other threads:[~2026-11-20  8:18 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  7:41 [PATCH bpf-next 00/49] bpf: Verify in passes, with equations in the state Alexei Starovoitov
2026-11-20  7:41 ` [PATCH bpf-next 01/49] bpf: Look for bpf_clone_redirect() once in check_recursion() Alexei Starovoitov
2026-11-20  7:41 ` [PATCH bpf-next 02/49] bpf: Make stack liveness faster Alexei Starovoitov
2026-11-20  8:01   ` sashiko-bot
2026-11-20  8:24   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 03/49] bpf: Delete the old main pass of the verifier Alexei Starovoitov
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 04/49] bpf: Delete scalar evolution Alexei Starovoitov
2026-11-20  8:03   ` sashiko-bot
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 05/49] bpf: Limit the cost and the memory of a load Alexei Starovoitov
2026-11-20  8:00   ` sashiko-bot
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 06/49] bpf: Record what each insn reads and writes Alexei Starovoitov
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 07/49] bpf: Name an id after the xreg that has it Alexei Starovoitov
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 08/49] bpf: Do not fail a check because a state has fewer values Alexei Starovoitov
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  8:39   ` sashiko-bot
2026-11-20  7:41 ` [PATCH bpf-next 09/49] bpf: Check fixups in the main pass and keep a snapshot of them Alexei Starovoitov
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 10/49] bpf: Reject a program with a call that needs two rewrites Alexei Starovoitov
2026-11-20  7:41 ` [PATCH bpf-next 11/49] bpf: Put a barrier where no mask fits Alexei Starovoitov
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 12/49] bpf: Keep more of what is known about a number Alexei Starovoitov
2026-11-20  8:18   ` sashiko-bot [this message]
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 13/49] bpf: Remember how many bytes of a packet are checked Alexei Starovoitov
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 14/49] bpf: Mark a state that no run of the program has Alexei Starovoitov
2026-11-20  8:24   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 15/49] bpf: Peel the first trips of a loop and join the other trips Alexei Starovoitov
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 16/49] bpf: Add equations and their arithmetic Alexei Starovoitov
2026-11-20  8:24   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 17/49] bpf: Keep a table of equations in each state Alexei Starovoitov
2026-11-20  8:17   ` sashiko-bot
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 18/49] bpf: Refine all related numbers after a jump Alexei Starovoitov
2026-11-20  7:41 ` [PATCH bpf-next 19/49] bpf: Make equations from ALU, spill, fill and call insns Alexei Starovoitov
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  8:26   ` sashiko-bot
2026-11-20  7:41 ` [PATCH bpf-next 20/49] bpf: Delete the equations that say nothing Alexei Starovoitov
2026-11-20  8:25   ` bot+bpf-ci
2026-11-20  7:41 ` [PATCH bpf-next 21/49] bpf: Compare states by join_key, then by value Alexei Starovoitov
2026-11-20  8:22   ` sashiko-bot
2026-11-20  7:41 ` [PATCH bpf-next 22/49] bpf: Continue a pass after an unproven insn Alexei Starovoitov
2026-11-20  7:41 ` [PATCH bpf-next 23/49] bpf: Find the xregs that an unproven insn depends on Alexei Starovoitov
2026-11-20  7:41 ` [PATCH bpf-next 24/49] bpf: Keep two states apart if data and control deps differ Alexei Starovoitov
2026-11-20  7:41 ` [PATCH bpf-next 25/49] bpf: Join any two states that have the same join_key Alexei Starovoitov
2026-11-20  8:25   ` sashiko-bot
2026-11-20  7:41 ` [PATCH bpf-next 26/49] bpf: Check the equations when a state is pruned or joined Alexei Starovoitov
2026-11-20  7:41 ` [PATCH bpf-next 27/49] bpf: Guess the equations of a join Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 28/49] bpf: Prune or join each state that arrives Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 29/49] bpf: Order the pending states and free the states that are done Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 30/49] bpf: Get the trip count from the trip index Alexei Starovoitov
2026-11-20  8:22   ` sashiko-bot
2026-11-20  7:42 ` [PATCH bpf-next 31/49] bpf: Give a loop a checked trip count or may_goto Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 32/49] bpf: Use the equations in the join rule Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 33/49] bpf: Verify a static function once for each instance Alexei Starovoitov
2026-11-20  8:33   ` sashiko-bot
2026-11-20  7:42 ` [PATCH bpf-next 34/49] bpf: Partition the states after an error Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 35/49] bpf: Reproduce an error on one path, with no joins Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 36/49] bpf: Do not let a join raise what a program requires Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 37/49] bpf: Verify in passes Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 38/49] bpf: Make a returned pointer to the stack unreadable Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 39/49] bpf: Keep two states apart if a live xreg has two types Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 40/49] bpf: Check the body of a counted loop once Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 41/49] bpf: Refine the copies of a number that AND or OR splits Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 42/49] bpf: Allow a range of offsets for a constant string Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 43/49] bpf: Keep spilled pointers at a range of stack offsets Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 44/49] selftests/bpf: Adjust tests to the new log text Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 45/49] selftests/bpf: Adjust tests that get another verdict or may_goto Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 46/49] selftests/bpf: Test barriers and far pointers Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 47/49] selftests/bpf: Test passes, instances, precision and the failing path Alexei Starovoitov
2026-11-20  8:30   ` sashiko-bot
2026-11-20  7:42 ` [PATCH bpf-next 48/49] selftests/bpf: Test equations Alexei Starovoitov
2026-11-20  7:42 ` [PATCH bpf-next 49/49] bpf, docs: Rewrite verifier.rst Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224702@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox