From: sashiko-bot@kernel.org
To: "Mike Bazov" <mike.bazov@gmail.com>
Cc: bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 1/3] bpf: Don't WARN when bpf_perf_event_output() nests too deep
Date: Fri, 20 Nov 2026 11:03:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-224980@kernel.org> (raw)
In-Reply-To: <20261120-bpf-raw-tp-regs-preempt-v3-1-ec109009a5d2@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] bpf: missing Fixes: trailer for bpf_perf_event_output()
WARN_ON_ONCE() fix
--
commit ae922aea5dc145502d3e9cea52835a863d8d8bb7
Author: Mike Bazov <mike.bazov@gmail.com>
> bpf: Don't WARN when bpf_perf_event_output() nests too deep
>
> bpf_perf_event_output() takes one of three per-CPU perf_sample_data
> slots per nesting level, and fails with -EBUSY and a WARN_ON_ONCE() when
> it is entered a fourth time on a CPU. Programs get there without any
> bug: a kprobe program calls it, and fentry programs on
> perf_event_output() call it again from inside. Each program's own
> recursion check lets it in once, so three of them reach the fourth
> level. With panic_on_warn, that takes the machine down.
>
> Keep the -EBUSY and drop the warning, as commit 3880cdbed1c4 ("bpf: Fix
> WARN() in get_bpf_raw_tp_regs") did for the raw tracepoint regs slots.
>
> Signed-off-by: Mike Bazov <mike.bazov@gmail.com>
[Severity: Low]
As with commit 3880cdbed1c4 ("bpf: Fix WARN() in get_bpf_raw_tp_regs"),
should this include a Fixes: tag for the commit that added the
WARN_ON_ONCE()?
Fixes: 9594dc3c7e71 ("bpf: fix nested bpf tracepoints with per-cpu data")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-bpf-raw-tp-regs-preempt-v3-0-ec109009a5d2@gmail.com?part=1
next prev parent reply other threads:[~2026-11-20 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 10:59 [PATCH bpf-next v3 0/3] bpf: Use an on-stack pt_regs in the raw tracepoint helpers Mike Bazov via B4 Relay
2026-11-20 10:59 ` [PATCH bpf-next v3 1/3] bpf: Don't WARN when bpf_perf_event_output() nests too deep Mike Bazov via B4 Relay
2026-11-20 11:03 ` sashiko-bot [this message]
2026-11-20 10:59 ` [PATCH bpf-next v3 2/3] bpf: Limit nesting of mmap_read_trylock() in BPF helpers Mike Bazov via B4 Relay
2026-11-20 10:59 ` [PATCH bpf-next v3 3/3] bpf: Use an on-stack pt_regs in the raw tracepoint helpers Mike Bazov via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224980@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mike.bazov@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox