BPF List
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Omokefe Emmanuel Onanaroghene" <emmaonana18@gmail.com>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH net-next v5 2/3] selftests: net: veth: propagate channel-check failures to exit status
Date: Sun, 22 Nov 2026 18:28:09 +0000	[thread overview]
Message-ID: <sashiko-outbox-228180@kernel.org> (raw)
In-Reply-To: <20261121182217.4609-3-emmaonana18@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests: net: veth: missing Fixes trailer for chk_channels()
  fix
--

commit 5d20ccb90ecdb7366b108efa1d9fec12aee9201e
Author: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>

> selftests: net: veth: propagate channel-check failures to exit status
>
> chk_channels() reports mismatches with a "fail" line but never sets
> ret, so the script exits 0 even when channel counts are wrong. Every
> other check helper in the file (__chk_flag, chk_xdp_feature, chk_gro)
> sets ret=1 on failure, and all chk_channels() call sites expect the
> check to pass. Set ret=1 on mismatch.
>
> Tested-by: Tianyi Gao <tianyi@cloudflare.com>
> Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>

[Severity: Low]
This fixes a bug in chk_channels() where channel count mismatches did not
cause the script to fail.  Should this include a Fixes tag?

  Fixes: 1ec2230fc721 ("selftests: net: veth: add tests for set_channel")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121182217.4609-1-emmaonana18@gmail.com?part=2

  reply	other threads:[~2026-11-22 18:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 18:22 [PATCH net-next v5 0/3] selftests: net: veth: propagate check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 1/3] selftests: net: veth: derive invalid-tx test value from kernel max Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 2/3] selftests: net: veth: propagate channel-check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-22 18:28   ` sashiko-bot [this message]
2026-11-21 18:22 ` [PATCH net-next v5 3/3] selftests: net: veth: propagate bad-settings check " Omokefe Emmanuel Onanaroghene
2026-11-22 18:28   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-228180@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=emmaonana18@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox