From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: HungTsung Huang <Jason.Huang2@infineon.com>
Cc: linux-wireless@vger.kernel.org, johannes.berg@intel.com,
johannes@sipsolutions.net, hsin-hung.li@cypress.com,
linux-kernel@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
wlan-kernel-dev-list@infineon.com, jeff.johnson@oss.qualcomm.com,
Carella Chen <carella.chen@infineon.com>
Subject: Re: [PATCH v5 1/5] wifi: nl80211: add roam offload extended feature
Date: Tue, 1 Sep 2026 10:56:05 +0200 [thread overview]
Message-ID: <02c6f660-68f7-488b-a600-279e3a7f272e@broadcom.com> (raw)
In-Reply-To: <20260901071424.GA1876155@ISCN5CG5251XQT.infineon.com>
On 01/09/2026 09:14, HungTsung Huang wrote:
> Hi Arend,
>
>> Actually there is a checkpatch warning that line with the STA_1X check
>> is 82 characters. So my suggestion please make it FAST_ROAMING instead
>> of ROAM_OFFLOAD and swap the two checks to fix the checkpatch warning.
>>
> Thank you for your suggestion. We will rename it to NL80211_EXT_FEATURE_FAST_ROAM_OFFLOAD.
> The name reflects that userspace offloads fast-roaming handling to the driver/firmware,
> and it covers both FT and OKC. We will also reorder the checks to avoid the line-length warning.
As this is indicating a driver feature the "_OFFLOAD" part is implied.
At least that is how I look at it. With the 80 char limit the long name
can be a drag in places.
Regards,
Arend
next prev parent reply other threads:[~2026-09-01 8:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 7:56 [PATCH v5 0/5] brcmfmac: add FT/OKC roaming offload support Jason Huang
2026-08-21 7:56 ` [PATCH v5 1/5] wifi: nl80211: add roam offload extended feature Jason Huang
2026-08-22 18:36 ` Arend van Spriel
2026-08-30 9:14 ` Arend van Spriel
2026-09-01 7:14 ` HungTsung Huang
2026-09-01 8:56 ` Arend van Spriel [this message]
2026-09-04 8:38 ` Johannes Berg
2026-08-21 7:56 ` [PATCH v5 2/5] wifi: brcmfmac: detect firmware FBT and OKC support Jason Huang
2026-08-21 7:56 ` [PATCH v5 3/5] wifi: brcmfmac: add PMK programming for firmware roaming offload Jason Huang
2026-08-21 7:56 ` [PATCH v5 4/5] wifi: brcmfmac: report port authorization after offloaded roaming Jason Huang
2026-08-22 18:24 ` [PATCH v5 0/5] brcmfmac: add FT/OKC roaming offload support Arend van Spriel
2026-08-22 18:26 ` Arend van Spriel
2026-08-24 3:08 ` HungTsung Huang
2026-08-24 2:27 ` [PATCH v5 5/5] wifi: brcmfmac: advertise firmware roam " Jason Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02c6f660-68f7-488b-a600-279e3a7f272e@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Jason.Huang2@infineon.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=carella.chen@infineon.com \
--cc=hsin-hung.li@cypress.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wlan-kernel-dev-list@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox