From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f100.google.com (mail-oa1-f100.google.com [209.85.160.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E74C7238C1A for ; Thu, 30 Oct 2025 13:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761830832; cv=none; b=tzB6bmG1MLHrZtGDA8k/xMoaxTGe3JiQe1h44a6+sYbdqcwy5n4oKCHZWhr1njNf9XEsLPfP/oRM6vw8Lf1OHxrbUChrovvYpisVAegY8z4XklLAXSbCo6orus+BGB3TJUhTC6oLgVm6G7a+x6NfS1s6W+zj4bDFhG1FbF8Y5e8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761830832; c=relaxed/simple; bh=1qUD48hf7Zf4bL0s/Ql9Y1pI9LG/2BGYn8uIuRM7T6s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bBhqfNYXsOPCyjd2KyhdrXsWfDwRJ6M5pQDariz4laRiVoh736JIOh34sYc3KDByg1tT/18ehFw3w+z3snZ0CAjB/SKWYfxwKgSQnuwFeWHC2zr1fypuBdEuFCigK+Hdrt6MeWk2DKVu2Bf9vivu8wiT/QExuku4uyV8tMqdSVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=HPZQ3QxY; arc=none smtp.client-ip=209.85.160.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="HPZQ3QxY" Received: by mail-oa1-f100.google.com with SMTP id 586e51a60fabf-373b7e07182so696768fac.0 for ; Thu, 30 Oct 2025 06:27:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761830830; x=1762435630; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dMXWIu8U60uApRCrqyrIhfDspTa+9zuuI22qzRz3bTA=; b=khfzeS7R7b5MTY96osDuQtyMEjydrWr6DB01PZJUQuVYjY9PvuRsowTLRck0GnXcFZ UUrhH7rVqck9h+Dw5m6JODFeKWbw3cBNOmbauhg2PwGVMZ3mivFiYAZIf9CIE8+fu9u3 evDF0uNUdxEviJvR4B4MyPINYtBN07KrFqhhXcXs7gugyxhniPoPJPkAcz11V7/5tKt/ Zs670heMwkSqCBWDJVyjcbUt/1QH56Yp9birPEuURXmj8oIfbmd7RktuKWd4MOvWxtNw MYubWMSPT15YFOX+yxY1z74sOYd8LiemUoulzE8Gt7eKG0uenptngrXbI3ej4GFJAD2u sGRQ== X-Forwarded-Encrypted: i=1; AJvYcCXO65pp7EzLBwiGgfbIRD9xtAOW6FeXMCq8p+M8xOFv17zzhc7RpoNzd/Jp9U10W45H1iSOFflheic=@lists.linux.dev X-Gm-Message-State: AOJu0YzCEs5JVAYvnjZJKsMf8V+02TE20h7O7FnLmPQBUdC2xUOb5nol 09WPR1b7RJ/NLoboLx1sLiYiP8NK/Vkk7gg40ZXdQacj3WY6Prv+b/IpMI3rtb0uymU3r41I/ZB wCdk3PtIBXppGUlDqzzjr5rl7PY7flSvankitPLA5MZ7cuJeLgrOW2wbqliwjMFUMDjQOLBOe7k sbgAlDrgEtyMAFT3XwJiYDF2pbQYxcZgXjLFnPY+rm/iJmqpNu9LFDqvCe09rURu9AobnWHPAd0 ofY4RF+jXQHCKA/UpSiSA== X-Gm-Gg: ASbGnctkWQkaWzFZWhX1BFzKeFAhFB11vzyPB1Gi/XEp1o5XzxWJJ4vHzP5PV35URqj EwyO6gCqe6iRZZqVR0ryYvG/tg5sZiPYq6vf4FHLuYErlRSydh2eP6By3DZDkWIBcDoOnNL6TVD hN8YJ6BgzelKpJOo3hb0FY4gK+JkJLZ9VZTVLJu8worioX1RwPm6EK3FMWQeHJt4fvZaT6BF5+T jwp1ng+7LMzPnOC0vCS5jWR5hYh5ed+GiX4bxQ+HJy8thXaisRHd/zNAqjQ2p5+6d8OrxhisXdT mGAcUy08oNUSlae+R79/EoalNhtcCDyCOORWvhK2SeKNs4usmWYz+do7VyPFnBy6GrpDgg+ccWL S9KhdrpBkjIEarLamNxocJFBHInnBYCPmdfc9WT6wz/XlpAaPoadRdsCx8BlkXvJk6UnIW/KmBH lTnLCoM3nr+dpHDh10k0prG6MHsWcIuTI6Xn9gNrgf X-Google-Smtp-Source: AGHT+IHscwSI1a3AIf9Nt++WUXIZJqd9YOtoxiWpXwcDMKxi0mdn+5QAegt53iR3P4HRzMvZCcEfG4jAtRDZ X-Received: by 2002:a05:6870:969e:b0:343:a20a:3feb with SMTP id 586e51a60fabf-3d74791f47dmr3450833fac.37.1761830829856; Thu, 30 Oct 2025 06:27:09 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-3d1e3a577f5sm1516519fac.16.2025.10.30.06.27.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Oct 2025 06:27:09 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-86df46fa013so247033185a.2 for ; Thu, 30 Oct 2025 06:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1761830829; x=1762435629; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dMXWIu8U60uApRCrqyrIhfDspTa+9zuuI22qzRz3bTA=; b=HPZQ3QxYUoYceDilrRZxFMZ7DarAEDkGMi6fwd8V6nNQpw3VrrtKmUa05JFCxNwczt FQGugwnp7eIxQIOsAX31qXjT/2AZzvcFcrzXE9VEgm3O54+5UOqhhS3t4KUNhy0ucUY7 nxDcODbTbOPpOqSOSNAFCEc3gr/JiE89iP+MM= X-Forwarded-Encrypted: i=1; AJvYcCUlLfnoc5QgqftrwsMBJzkFcwc5yVrFpwEZ5/EKnZWiZi8JCSDp/6TmPp0XUjpz8ahLncwfdgCKbec=@lists.linux.dev X-Received: by 2002:a05:620a:45a7:b0:82e:6ec8:9887 with SMTP id af79cd13be357-8a8e3b9b881mr886990685a.24.1761830828814; Thu, 30 Oct 2025 06:27:08 -0700 (PDT) X-Received: by 2002:a05:620a:45a7:b0:82e:6ec8:9887 with SMTP id af79cd13be357-8a8e3b9b881mr886986885a.24.1761830828170; Thu, 30 Oct 2025 06:27:08 -0700 (PDT) Received: from [10.176.2.229] ([192.19.176.250]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f25e8685fsm1259974385a.50.2025.10.30.06.27.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Oct 2025 06:27:07 -0700 (PDT) Message-ID: <17ed1078-772e-4c01-ba7c-63c58d89c0d9@broadcom.com> Date: Thu, 30 Oct 2025 14:27:05 +0100 Precedence: bulk X-Mailing-List: brcm80211@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: brcmfmac: Add null pointer check to brcmf_acpi_probe To: Li Qiang , linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com Cc: linux-kernel@vger.kernel.org References: <20251015071607.96415-1-liqiang01@kylinos.cn> Content-Language: en-US From: Arend van Spriel Autocrypt: addr=arend.vanspriel@broadcom.com; keydata= xsFNBGP96SABEACfErEjSRi7TA1ttHYaUM3GuirbgqrNvQ41UJs1ag1T0TeyINqG+s6aFuO8 evRHRnyAqTjMQoo4tkfy21XQX/OsBlgvMeNzfs6jnVwlCVrhqPkX5g5GaXJnO3c4AvXHyWik SOd8nOIwt9MNfGn99tkRAmmsLaMiVLzYfg+n3kNDsqgylcSahbd+gVMq+32q8QA+L1B9tAkM UccmSXuhilER70gFMJeM9ZQwD/WPOQ2jHpd0hDVoQsTbBxZZnr2GSjSNr7r5ilGV7a3uaRUU HLWPOuGUngSktUTpjwgGYZ87Edp+BpxO62h0aKMyjzWNTkt6UVnMPOwvb70hNA2v58Pt4kHh 8ApHky6IepI6SOCcMpUEHQuoKxTMw/pzmlb4A8PY//Xu/SJF8xpkpWPVcQxNTqkjbpazOUw3 12u4EK1lzwH7wjnhM3Fs5aNBgyg+STS1VWIwoXJ7Q2Z51odh0XecsjL8EkHbp9qHdRvZQmMu Ns8lBPBkzpS7y2Q6Sp7DcRvDfQQxPrE2sKxKLZVGcRYAD90r7NANryRA/i+785MSPUNSTWK3 MGZ3Xv3fY7phISvYAklVn/tYRh88Zthf6iDuq86m5mr+qOO8s1JnCz6uxd/SSWLVOWov9Gx3 uClOYpVsUSu3utTta3XVcKVMWG/M+dWkbdt2KES2cv4P5twxyQARAQABzS9BcmVuZCB2YW4g U3ByaWVsIDxhcmVuZC52YW5zcHJpZWxAYnJvYWRjb20uY29tPsLBhwQTAQgAMRYhBLX1Z69w T4l/vfdb0pZ6NOIYA/1RBQJj/ek9AhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQlno04hgD/VGw 8A//VEoGTamfCks+a12yFtT1d/GjDdf3i9agKMk3esn08JwjJ96x9OFFl2vFaQCSiefeXITR K4T/yT+n/IXntVWT3pOBfb343cAPjpaZvBMh8p32z3CuV1H0Y+753HX7gdWTEojGWaWmKkZh w3nGoRZQEeAcwcF3gMNwsM5Gemj7aInIhRLUeoKh/0yV85lNE1D7JkyNheQ+v91DWVj5/a9X 7kiL18fH1iC9kvP3lq5VE54okpGqUj5KE5pmHNFBp7HZO3EXFAd3Zxm9ol5ic9tggY0oET28 ucARi1wXLD/oCf1R9sAoWfSTnvOcJjG+kUwK7T+ZHTF8YZ4GAT3k5EwZ2Mk3+Rt62R81gzRF A6+zsewqdymbpwgyPDKcJ8YUHbqvspMQnPTmXNk+7p7fXReVPOYFtzzfBGSCByIkh1bB45jO +TM5ZbMmhsUbqA0dFT5JMHjJIaGmcw21ocgBcLsJ730fbLP/L08udgWHywPoq7Ja7lj5W0io ZDLz5uQ6CEER6wzD07vZwSl/NokljVexnOrwbR3wIhdr6B0Hc/0Bh7T8gpeM+QcK6EwJBG7A xCHLEacOuKo4jinf94YQrOEMnOmvucuQRm9CIwZrQ69Mg6rLn32pA4cK4XWQN1N3wQXnRUnb MTymLAoxE4MInhDVsZCtIDFxMVvBUgZiZZszN33OwU0EY/3pIgEQAN35Ii1Hn90ghm/qlvz/ L+wFi3PTQ90V6UKPv5Q5hq+1BtLA6aj2qmdFBO9lgO9AbzHo8Eizrgtxp41GkKTgHuYChijI kdhTVPm+Pv44N/3uHUeFhN3wQ3sTs1ZT/0HhwXt8JvjqbhvtNmoGosZvpUCTwiyM1VBF/ICT ltzFmXd5z7sEuDyZcz9Q1t1Bb2cmbhp3eIgLmVA4Lc9ZS3sK1UMgSDwaR4KYBhF0OKMC1OH8 M5jfcPHR8OLTLIM/Thw0YIUiYfj6lWwWkb82qa4IQvIEmz0LwvHkaLU1TCXbehO0pLWB9HnK r3nofx5oMfhu+cMa5C6g3fBB8Z43mDi2m/xM6p5c3q/EybOxBzhujeKN7smBTlkvAdwQfvuD jKr9lvrC2oKIjcsO+MxSGY4zRU0WKr4KD720PV2DCn54ZcOxOkOGR624d5bhDbjw1l2r+89V WLRLirBZn7VmWHSdfq5Xl9CyHT1uY6X9FRr3sWde9kA/C7Z2tqy0MevXAz+MtavOJb9XDUlI 7Bm0OPe5BTIuhtLvVZiW4ivT2LJOpkokLy2K852u32Z1QlOYjsbimf77avcrLBplvms0D7j6 OaKOq503UKfcSZo3lF70J5UtJfXy64noI4oyVNl1b+egkV2iSXifTGGzOjt50/efgm1bKNkX iCVOYt9sGTrVhiX1ABEBAAHCwXYEGAEIACAWIQS19WevcE+Jf733W9KWejTiGAP9UQUCY/3p PgIbDAAKCRCWejTiGAP9UaC/EACZvViKrMkFooyACGaukqIo/s94sGuqxj308NbZ4g5jgy/T +lYBzlurnFmIbJESFOEq0MBZorozDGk+/p8pfAh4S868i1HFeLivVIujkcL6unG1UYEnnJI9 uSwUbEqgA8vwdUPEGewYkPH6AaQoh1DdYGOleQqDq1Mo62xu+bKstYHpArzT2islvLdrBtjD MEzYThskDgDUk/aGPgtPlU9mB7IiBnQcqbS/V5f01ZicI1esy9ywnlWdZCHy36uTUfacshpz LsTCSKICXRotA0p6ZiCQloW7uRH28JFDBEbIOgAcuXGojqYx5vSM6o+03W9UjKkBGYFCqjIy Ku843p86Ky4JBs5dAXN7msLGLhAhtiVx8ymeoLGMoYoxqIoqVNaovvH9y1ZHGqS/IYXWf+jE H4MX7ucv4N8RcsoMGzXyi4UbBjxgljAhTYs+c5YOkbXfkRqXQeECOuQ4prsc6/zxGJf7MlPy NKowQLrlMBGXT4NnRNV0+yHmusXPOPIqQCKEtbWSx9s2slQxmXukPYvLnuRJqkPkvrTgjn5d eSE0Dkhni4292/Nn/TnZf5mxCNWH1p3dz/vrT6EIYk2GSJgCLoTkCcqaM6+5E4IwgYOq3UYu AAgeEbPV1QeTVAPrntrLb0t0U5vdwG7Xl40baV9OydTv7ghjYZU349w1d5mdxg== In-Reply-To: <20251015071607.96415-1-liqiang01@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 10/15/2025 9:16 AM, Li Qiang wrote: > devm_kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. Thanks. However, it does not make sense to just bail out. settings->board_type will still be NULL and apparently that is not an issue. It is used to fill the firmware request (see struct brcmf_fw_request [1]) which is done for PCIe devices in brcmf_pcie_prepare_fw_request() [2]. So struct brcmf_fw_request::board_types array may hold NULL pointers which is not an issue. So this patch does not solve a problem. Regards, Arend [1] https://elixir.bootlin.com/linux/v6.17.5/source/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.h#L67 [2] https://elixir.bootlin.com/linux/v6.17.5/source/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c#L2264 > Fixes: 0f485805d008a ("wifi: brcmfmac: acpi: Add support for fetching Apple ACPI properties") > Signed-off-by: Li Qiang > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c > index c4a54861bfb4..f8f6433bdf69 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c > @@ -25,6 +25,8 @@ void brcmf_acpi_probe(struct device *dev, enum brcmf_bus_type bus_type, > settings->board_type = devm_kasprintf(dev, GFP_KERNEL, > "apple,%s", > o->string.pointer); > + if (!settings->board_type) > + return; > } else { > brcmf_dbg(INFO, "No ACPI module-instance\n"); > return;