From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D52871DDC12; Sun, 26 Jan 2025 15:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737903646; cv=none; b=QPEvF6XgXV6OOEPTXPcIizkYc5xaGRzz1XXA218p5V6nme/IIWi99M1il5sWyfYhcS3ExZRFfcE4IMyskd55bkFvucIXOM+8dD46PAVxI8/2pusubvwZbvST36jEJNbNfmlSQCeRh5gofDI3ru22h4c5TwFt8aZ8crH+7tATMKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737903646; c=relaxed/simple; bh=CGiuOyRCSz8cyy9BQptoIIFiYUhJkgbuW56cfCSSqqM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rfjT+cdDHaBza4+LVqVLqGzgxC0GkHDgcBx1JS11k29oRGmxCZKTRd1c32CWuEmi8puaEZIp6oFJr32/aMr4KbSKoBgTNaLCAFYHZtffPyuOZLKDEjZ+q8pIkpJP6iExS67XqUK5nJy6EyDWufr5dW83w6/tPozNmDaPOOBxR/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E2Twt5N5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E2Twt5N5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FFB6C4CED3; Sun, 26 Jan 2025 15:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737903645; bh=CGiuOyRCSz8cyy9BQptoIIFiYUhJkgbuW56cfCSSqqM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E2Twt5N5LDBj8aUu3WRBSNU40BrgeZhw+CSMLdVcYcxUqKn9QNa0EW2Zm5b88Fhx5 ioAgoWwcccxZgrFPxfJQlsnCfmkbqe2AzJyjW4sacjbKWg7a5sHfGAE1Xhf5jHDePC C8ka1GjeSJVuv8rnaXd4KZVVaDwrdYDjXcf+RBZ+w/nvQwJ2hCBxAdXaAgn/68puqS dS6CmZiZy+Csdpuh6pDos4g58AQiDbSLz5pVi0R69GPyna32zEgyasEqw28smITEx4 I3B0z/6Mdw9szZnuVd/Bz520Sgkd9zsSPLdgMWwDdkvcYydNjO+/rYnc+UkcaJjEOb Mg5JqHyk56H6Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dmitry Antipov , Arend van Spriel , Kalle Valo , Sasha Levin , johannes.berg@intel.com, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com Subject: [PATCH AUTOSEL 6.13 08/35] wifi: brcmsmac: add gain range check to wlc_phy_iqcal_gainparams_nphy() Date: Sun, 26 Jan 2025 10:00:02 -0500 Message-Id: <20250126150029.953021-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250126150029.953021-1-sashal@kernel.org> References: <20250126150029.953021-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: brcm80211@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.13 Content-Transfer-Encoding: 8bit From: Dmitry Antipov [ Upstream commit 3f4a0948c3524ae50f166dbc6572a3296b014e62 ] In 'wlc_phy_iqcal_gainparams_nphy()', add gain range check to WARN() instead of possible out-of-bounds 'tbl_iqcal_gainparams_nphy' access. Compile tested only. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Antipov Acked-by: Arend van Spriel Signed-off-by: Kalle Valo Link: https://patch.msgid.link/20241210070441.836362-1-dmantipov@yandex.ru Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c index d69879e1bd870..d362c4337616b 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c @@ -23423,6 +23423,9 @@ wlc_phy_iqcal_gainparams_nphy(struct brcms_phy *pi, u16 core_no, break; } + if (WARN_ON(k == NPHY_IQCAL_NUMGAINS)) + return; + params->txgm = tbl_iqcal_gainparams_nphy[band_idx][k][1]; params->pga = tbl_iqcal_gainparams_nphy[band_idx][k][2]; params->pad = tbl_iqcal_gainparams_nphy[band_idx][k][3]; -- 2.39.5