From: Kalle Valo <kvalo@kernel.org>
To: Yuesong Li <liyuesong@vivo.com>
Cc: kees@kernel.org, johannes.berg@intel.com, neal@gompa.dev,
a@bayrepo.ru, justinstitt@google.com, marcan@marcan.st,
j@jannau.net, wsa+renesas@sang-engineering.com,
brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH net-next v1] brcmfmac: Convert to use ERR_CAST()
Date: Thu, 29 Aug 2024 15:23:25 +0300 [thread overview]
Message-ID: <87ed67ecw2.fsf@kernel.org> (raw)
In-Reply-To: <20240829112844.3193582-1-liyuesong@vivo.com> (Yuesong Li's message of "Thu, 29 Aug 2024 19:28:44 +0800")
Yuesong Li <liyuesong@vivo.com> writes:
> Use ERR_CAST() as it is designed for casting an error pointer to
> another type.
>
> This macro utilizes the __force and __must_check modifiers, which instruct
> the compiler to verify for errors at the locations where it is employed.
>
> Signed-off-by: Yuesong Li <liyuesong@vivo.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Several problems:
* wireless patches go to wireless-next, not net-next
* "wifi:" missing from title
* you forgot to cc linux-wireless
Please fix these and submit v2. And please read the wiki link below.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-08-29 12:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 11:28 [PATCH net-next v1] brcmfmac: Convert to use ERR_CAST() Yuesong Li
2024-08-29 12:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed67ecw2.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=a@bayrepo.ru \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=j@jannau.net \
--cc=johannes.berg@intel.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liyuesong@vivo.com \
--cc=marcan@marcan.st \
--cc=neal@gompa.dev \
--cc=opensource.kernel@vivo.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox