From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C84721DE2B9 for ; Thu, 27 Feb 2025 17:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740677828; cv=none; b=ngLjkUBwWPGz5X1qZjtsjtsq9TSJ7uo45Ya6Ih0iParAKCmkKmX4iB0MhHBn8njbBClphiHfSYQ2LLw+WTvU2wH+strseWM8gv6zcP1BqePE9mUgl+3LF7PxJZA+gNhc7xHi1utzhKBl0LPMq97QjtLZTlBHqmjiEV9rRDA/gV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740677828; c=relaxed/simple; bh=3VhhTqGt87a5LXVZ8xAbJKCD+r0MSBo9AvP4EXdhZvc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ezwsb0trh6xyZeC+AoW6+B+ljnMChTreoH31oFLGPbRllrsMUlUjfhGqF33Ol1UH0l2W94vCQxc6AW+5+flmKmwHXo2VWkYwpm8GeT0u4ZqoF2IVVKy4ZqlYyE+00iA9tSHrrIPMbw0iejaa7+kzwWEDMDSwR68BAlLu+ShxVzc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LAuzESKh; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LAuzESKh" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2234e4b079cso23684285ad.1 for ; Thu, 27 Feb 2025 09:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740677826; x=1741282626; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VUAFuA6WyxlqIwMao9P+DyP+C2TxjteBYJ1MyyDLQfw=; b=LAuzESKhAEpP+N86sIMh6miS7qX0O/GqvPF1vrL+PftBXP5PTgrRzISztQwTLaGurn vcNiXHFqbROVt49WkzOnqb3OJPrY/q8p9wEQRtx3WUDA1Tqt9xncZFA2aHY7cRqW2v/e MaEhHCMRBud50FDhSeye7/k/Z7m4csYXqMkG00A3RZWzhN4xIkSmBMTxiFFOzYMbk7s5 kfuU30j7M3zv/0afdgb81hH1d/Sma1uOjQ+B4/EJ6p4+x1ZID/zCXtDLAxoMv8THXRnP fHbsFTsFca1C4fZWJ087dYl5w4ss/Dp1L/RoyPDMcS9lylTsGv45Xnn8oNDItcfQ/h+d zxOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740677826; x=1741282626; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VUAFuA6WyxlqIwMao9P+DyP+C2TxjteBYJ1MyyDLQfw=; b=UjIdDDqU66bg2iCQFsNNAQnAFD3CA+Dn4Exg6h/N9JklEGG6DKIzCN9IEHMxeGvTM1 TvrNdlSbgBX5Ihr09sHbSK4kjRPZbHrjIEQcaCDg8f4FNxy1VBgXhrDytIC78VNK7p+6 dBvAq9DOjnfz2lnu8Fkefz4AhXYSf8RWtFZYdBzjtR1WBlzo1oFnNN+mbuHd/FnAVX9t ne4BWV48J1EuAarzEotrCsEbe/9RSA28O+bRRV2BY/MaOA1yLlbZOnejTi7xv/AvLLve FNZ911iFUcXJ+CyttO5AnJRXX1ldUroMUriDTKruUrY69LpnUWBeRryEbpZ3joFxuaE2 vfRw== X-Forwarded-Encrypted: i=1; AJvYcCWOJNi3vQ8HXXXkScZmTBiuelRFG9QHuIYxVOEaSorg1qGEt7HLMl8Fybx0TwIVxZdmivyDXxIPeWo=@lists.linux.dev X-Gm-Message-State: AOJu0YyPAWKjuvECX73vNQhQClhm7P7a8GlIPOJp3OcbZbAAKbZJWPtB e+LmaX41rF+LcDIhjkR4zAaI4MS0XIsllnFOPNiLb9oEaRebeSWH X-Gm-Gg: ASbGncu6SAl43PV6Rq7XJ2jFZ+Tldcuc3QIG48ibu3hz9KAWhNkjW3frj15Hj4+AMjv pwh0Cj8QKLPa4PQMesynyVZ//km7HYgvcKH8Tap+N8J31F6+k2OgBtL6Mnzxo8wNR0mxc1AXWGp 2hplAVUo0uy95XFB1wGmX+eCithGzjeI8VjHR6bto4ZrzPV2cEx9iL1hxTFmvKniN0c1zKwfSJd ihUrqhti9fsNJytPbYA4RGidl/uYco4kw3lURlfpTE7qAKdF9+fpfP4NmN4UjdblQAnkky36vVG zPrY0DQmR//g3GnhUMTWz7qNRkX4keMs/mNjmYa9hhThrjcsmw== X-Google-Smtp-Source: AGHT+IGK2yvXxMwGzFuS4qAPXT9dc4oLUeTze+y8wAtciDVfBiItiQouqHwlR4imml9fxjD4qYJfDg== X-Received: by 2002:a05:6a20:9146:b0:1ee:d6da:b651 with SMTP id adf61e73a8af0-1f0fc993ffdmr22305716637.35.1740677825727; Thu, 27 Feb 2025 09:37:05 -0800 (PST) Received: from localhost (maglev-oncall.nvidia.com. [216.228.125.128]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-aee7de19d3fsm1745501a12.18.2025.02.27.09.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 09:37:05 -0800 (PST) Date: Thu, 27 Feb 2025 12:37:02 -0500 From: Yury Norov To: Jiri Slaby Cc: Kuan-Wei Chiu , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, akpm@linux-foundation.org, hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Yu-Chun Lin Subject: Re: [PATCH 02/17] bitops: Add generic parity calculation for u64 Message-ID: References: <20250223164217.2139331-1-visitorckw@gmail.com> <20250223164217.2139331-3-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: brcm80211@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 27, 2025 at 07:38:58AM +0100, Jiri Slaby wrote: > On 26. 02. 25, 19:33, Yury Norov wrote: > > > Not in cases where macros are inevitable. I mean, do we need parityXX() for > > > XX in (8, 16, 32, 64) at all? Isn't the parity() above enough for everybody? > > > > The existing codebase has something like: > > > > int ret; > > > > ret = i3c_master_get_free_addr(m, last_addr + 1); > > ret |= parity8(ret) ? 0 : BIT(7) > > > > So if we'll switch it to a macro like one above, it will become a > > 32-bit parity. It wouldn't be an error because i3c_master_get_free_addr() > > returns an u8 or -ENOMEM, and the error code is checked explicitly. > > > > But if we decide to go with parity() only, some users will have to > > call it like parity((u8)val) explicitly. Which is not bad actually. > > That cast looks ugly -- we apparently need parityXX(). (In this particular > case we could do parity8(last_addr), but I assume there are more cases like > this.) Thanks for looking up the case for this. This parity8() is used in just 2 drivers - i3c and hwmon/spd5118. The hwmon driver looks good. I3C, yeah, makes this implied typecast, which is nasty regardless. This is the new code, and I think if we all agree that generic parity() would be a better API, it's a good time to convert existing users now. Thanks, Yury