From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53D2F448B84 for ; Sun, 11 Oct 2026 19:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791747735; cv=none; b=lvcYdrhgHfKbDmj8tkHh2UQNENjBN7zkQDqJqxTytryZNaBKAuXIBcoHNJD6f952s81GmW8NYEXYuGd4Vm/L+ACbRcfAArWwW2EmVGGAkE/SffpnZnjnAMhT4fThNWj9nb3JTVZPU4mmozSbFp7CZDNFABvfl5/qaupi+WavZ64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791747735; c=relaxed/simple; bh=4AMJ4/YUrPp8c+UnnNwqZYiFxBTm23GrzrPTxaOoYuU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZjfApUC8HENvHcieANMjAOtBUoCUYmqG/HeCwwoyRRsf9toJr7w9r275QHFJY6Up090PT6JrqxQHFNOgNMrVhVhtkjSngpa9VBzIQD/63tO4v/NATaXnrwXEGN9HOzq0bauZVEHo6TJ7Or3eSWVweL5vNb+BRZNNrczHVfWve30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SR8mfWK4; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SR8mfWK4" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4a1880e1bf1so11643235e9.1 for ; Sun, 11 Oct 2026 12:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791747732; x=1792352532; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Z1QFtV7KI5OFWzwbAboD0j9bhs+VlQKq149o9ZSjG8g=; b=SR8mfWK4/HXsAFDwsx4NGxtNmvAN4qTcnh9CEE5KIHs+pOrqw36HnHXYvUW2cTNyzL wU40coBnzfZfbgBMrDgLXsZLl8IcD89Rg75ss2EtIr2/mSRJQ2sUTW1RTP3pOLV6aQH2 BPX+U6Y2X5tKVapFLPvIUupm7xR3JDgFMcn9QFiIfcaWGO4Sp52kjTKs+YFf1VJV0A1A BCYS2MHTTtTG94SHiIlDNf6FIwUXqCDbfHPU5RONT+LSr+iCqB3L45kIOSCLbUPqjRO6 aU0sati4K45oJ4zgk1qPjA5sjoRaYTMnCM5AjAql2aMsu3FuCD7V5Ctr/XGgKxdjQEXG MOjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791747732; x=1792352532; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Z1QFtV7KI5OFWzwbAboD0j9bhs+VlQKq149o9ZSjG8g=; b=bXsMcMCY/yCsZjkKahkbeh2KkALJ5wK/bWNDxNStH5QUBbglfqmYHn7fuXr0JuOtgT z9yn28p1kX1cytNpikI/SZQ57Dh7pW5PQWxnc89AMyCHQXXlx5lwY3xM+1/Gw4S69LJz CjQhVcUtGyT8epVNSdn5eDvLfdqFXhvNXsy186f9Hchbb5IbZIJl9DPWWxjvCHcgytDs vGn/Kb0B/73SwqnxvbdKykyiFuROxpwU2TaqOCUDsJkU+7kZ72GZxxaBbe9AYyRc2Thz 98LHXBhqoBz+Ya09c01ojy2w4tOXqg3RXEzpB40MmqzfQ5C1X2HjwPTzQKSafeZlZTbd CDog== X-Forwarded-Encrypted: i=1; AKwUvBxO2/ITsOMLL3VjrtLKTDMAXqVuYQNmMU+PTFriuRIsFsfgPkVzNpK8js80mnR0/MbOKpAtw3Wqdpk=@lists.linux.dev X-Gm-Message-State: AFq9FYKwP1uJB2hHLnQK9hi+r4g3sl2KK4aywcI7ot8AYEtM+0EOF2YV SRYVfe/j8Q/cTCUKYpyAqpEt1tQFZXufxOvvyGmQ6xizJusdo3quefGU X-Gm-Gg: AYBFou1XyNExDkyjqiCwwvBCijhq67z3BS3vRR0PjylwBtZpszbPaKmkFYNN/tq/xQi IIL7NQCWdVi2Rr69lYUyrLQJ4RwvcsDe/LKPGMLFSwlo8ykZyzZW9InSwtSW2XbzpG88Yxm91mi KUtx8bYijnLyGXFsq0S6BZziKydNdVOq/QBQgKNh61TCQAHGF1KJZ5rABJWViG5NbRRzPLdbSA4 vKCaBKVSCSPNsYdntTovzRzvIS+c+/rFPb+gAhFNrkxmceA1FS1h2EzzB2AIKxYtL8RbPXkdKJi Lo1ZKNEFiQHcu9DCyeKJUHTY4BX28bS8kV/fnD3wjDlHT3U0tk8oDbffq/EWupE9esCATKGEp5R Is4eeEF+UW0xRS7FR7WfoEjx2rKCoW7gLCEs3+P3S0XFuF4UVQJoYOACS5tFNnPCLOLVNniH1GG e9LPDYtNdR5Emis23XXz8q7yRBpt8NvuTdIzzk/rZrah97cSMzZU1vbUydAbWhsqUqTUrHrh/9i UVD5VoNiKhLHeDqH56U1fBIvpmaBCPIFKUd1EkuIauKMymk26ausjLE/B9dJfXfmEppqgf5Zoqz y8EQhj8jKsFidpiW/VoUWx2pmq/4UGirLAjfGoyxcW0+j76jFzTiPUFC1jeBZv1K3iehZe2ZE9Y Xrv4L X-Received: by 2002:a05:600c:34cf:b0:4a0:159b:d2a9 with SMTP id 5b1f17b1804b1-4a18e4d68aamr114369585e9.24.1791747732221; Sun, 11 Oct 2026 12:42:12 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-2a02-3100-a124-4001-d491-d32f-6b9f-21c5.310.pool.telefonica.de. [2a02:3100:a124:4001:d491:d32f:6b9f:21c5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a197c465b4sm89015105e9.3.2026.10.11.12.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2026 12:42:11 -0700 (PDT) Date: Sun, 11 Oct 2026 21:42:10 +0200 From: Karl Mehltretter To: Sebastian Andrzej Siewior Cc: linux-wireless@vger.kernel.org, Arend van Spriel , Clark Williams , Steven Rostedt , "David S. Miller" , Eric Dumazet , brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH] wifi: brcmfmac: avoid sleeping tx locks in netpoll contextg Message-ID: References: <20260930185417.61865-1-kmehltretter@gmail.com> <20261001075755.3MilPS2C@linutronix.de> <20261009160015.9YCN8Lt-@linutronix.de> Precedence: bulk X-Mailing-List: brcm80211@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261009160015.9YCN8Lt-@linutronix.de> On Fri, Oct 09, 2026 at 06:00:15PM +0100, Sebastian Andrzej Siewior wrote: > > > > Source inspection also identified 8139too and macb as candidates: their > > transmit paths take ordinary spinlock_t locks. I have not reproduced the > > warning with either driver. > > I just replied to the netconsole thread where I did suggest to lift the > local_irq_save() part. This would obsolete this. I've replied in the netpoll thread [1]. The netpoll candidate's RT locking tests look good so far on Pi 400 with unmodified brcmfmac. > > > The earlier netpoll/NBCON discussion concerns NAPI polling and > > scheduler-lock deadlocks, rather than this driver-lock warning: > > > > https://lore.kernel.org/linux-rt-devel/20260618111554.2n0pP_O9@linutronix.de/ > > There was no fan club behind this change and PeterZ hated it so I > dropped it. > But this deadlock should not happen with nbcon or do I mix up things? No, you're not mixing things up. > I don't mind if you have something to optimise the driver. But as far as > the netconsole part goes, I would try to kill it at the upper level so > the driver is not affected. Agreed. I'll hold the driver revision while we discuss the generic fix. The generic fix still doesn't address calls to brcmfmac with interrupts disabled from non-RT netconsole or atomic writes. I still need to compare the unmodified kernel and the netpoll candidate on hardware with firmware flow control enabled (brcmfmac.fcmode=1 or 2). [1] https://lore.kernel.org/r/asveuLDEf6a44bkD@gmail.com/ Karl