From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Jacobe Zang <jacobe.zang@wesion.com>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
Ondrej Jirman <megi@xff.cz>
Subject: Re: [RFT] wifi: brcmfmac: Add optional lpo clock enable support
Date: Fri, 2 Aug 2024 10:28:46 -0700 [thread overview]
Message-ID: <f2cc346e-63b0-4fb7-b954-5dc3e597b7e1@broadcom.com> (raw)
In-Reply-To: <20240802083400.166753-1-arend.vanspriel@broadcom.com>
On 8/2/24 01:34, Arend van Spriel wrote:
> From: Jacobe Zang <jacobe.zang@wesion.com>
>
> WiFi modules often require 32kHz clock to function. Add support to
> enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check
> to the top of brcmf_of_probe
>
> Co-developed-by: Ondrej Jirman <megi@xff.cz>
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> [arend: handle -EPROBE_DEFER scenario]
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
This looks fine for a cold boot case, how about handling suspend/resume
where the clock might have been disabled, do we need to deal with an
"always-on" Device Tree property as well as whether the device is
enabled for wake-up or not?
--
Florian
next prev parent reply other threads:[~2024-08-02 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 8:34 [RFT] wifi: brcmfmac: Add optional lpo clock enable support Arend van Spriel
2024-08-02 17:28 ` Florian Fainelli [this message]
2024-08-03 13:47 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2cc346e-63b0-4fb7-b954-5dc3e597b7e1@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=jacobe.zang@wesion.com \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox