From: "Valerio Granato" <contact@livenet.it>
To: bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH] net, bridge: print log message after state changed
Date: Thu, 17 Nov 2011 07:19:16 +0100 [thread overview]
Message-ID: <007b01cca4f0$f95e39b0$060ca8c0@sviluppo> (raw)
In-Reply-To: 20111114.020749.1176229013272872343.davem@davemloft.net
---- Original Message ----
From: "David Miller" <davem@davemloft.net>
To: <Wolfgang.Fritz@keymile.com>
Cc: <netdev@vger.kernel.org>; <shemminger@linux-foundation.org>;
<bridge@lists.linux-foundation.org>; <holger.brunck@keymile.com> Sent:
Monday, November 14, 2011 8:07 AM Subject: Re: [Bridge] [PATCH]
net,bridge: print log message after state changed
> I would never expect an "entering" message to print out after the
> event happens, and in fact I'd _always_ want to see it beforehand so
> that if the state change caused a crash or similar it'd be that much
> easier to pinpoint the proper location.
I think this is a really good point of view.
I agree.
Valerio
next prev parent reply other threads:[~2011-11-17 6:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 16:18 [Bridge] [PATCH] net, bridge: print log message after state changed Holger Brunck
2011-11-14 5:37 ` David Miller
2011-11-14 7:13 ` Fritz, Wolfgang
2011-11-14 7:07 ` David Miller
2011-11-14 9:09 ` Fritz, Wolfgang
2011-11-14 14:27 ` Joe Perches
2011-11-17 6:19 ` Valerio Granato [this message]
2011-11-17 19:23 ` David Lamparter
2011-11-17 22:40 ` Stephen Hemminger
2011-11-18 9:30 ` Holger Brunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007b01cca4f0$f95e39b0$060ca8c0@sviluppo' \
--to=contact@livenet.it \
--cc=bridge@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox