From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: "bridge@lists.linux-foundation.org" <bridge@lists.linux-foundation.org>
Subject: Re: [Bridge] [PATCH] BRIDGE: Do not suppress FDB learning after topology change when forward_delay is 0.
Date: Fri, 15 May 2009 10:34:40 +0100 [thread overview]
Message-ID: <1242380080.4341.91.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20090514083523.643b640b@nehalam>
On Thu, 2009-05-14 at 11:35 -0400, Stephen Hemminger wrote:
> Unless STP is enabled, br_topology_change is bogus. It looks like,
> the following would avoid the problem?
Yes, it does and it looks like a much better fix to me.
Thanks, Ian.
>
> --- a/net/bridge/br_stp.c 2009-05-14 08:33:01.795909321 -0700
> +++ b/net/bridge/br_stp.c 2009-05-14 08:34:32.839883992 -0700
> @@ -375,7 +375,8 @@ static void br_make_forwarding(struct ne
>
> if (br->forward_delay == 0) {
> p->state = BR_STATE_FORWARDING;
> - br_topology_change_detection(br);
> + if (p->br->stp_enable == BR_KERNEL_STP)
> + br_topology_change_detection(br);
> del_timer(&p->forward_delay_timer);
> }
> else if (p->br->stp_enabled == BR_KERNEL_STP)
>
>
next prev parent reply other threads:[~2009-05-15 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 11:01 [Bridge] [PATCH] BRIDGE: Do not suppress FDB learning after topology change when forward_delay is 0 Ian Campbell
2009-05-14 14:37 ` Ian Campbell
2009-05-14 15:35 ` Stephen Hemminger
2009-05-15 9:34 ` Ian Campbell [this message]
2009-05-15 10:08 ` Uli Luckas
2009-05-15 17:04 ` richardvoigt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242380080.4341.91.camel@zakaz.uk.xensource.com \
--to=ian.campbell@eu.citrix.com \
--cc=bridge@lists.linux-foundation.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox