From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Nicolas Dichtel Date: Tue, 28 Apr 2015 18:33:48 +0200 Message-Id: <1430238831-29966-2-git-send-email-nicolas.dichtel@6wind.com> In-Reply-To: <1430238831-29966-1-git-send-email-nicolas.dichtel@6wind.com> References: <1430238831-29966-1-git-send-email-nicolas.dichtel@6wind.com> Subject: [Bridge] [PATCH net 1/3] bridge/mdb: remove wrong use of NLM_F_MULTI List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: netdev@vger.kernel.org Cc: Cong Wang , bridge@lists.linux-foundation.org, dmitry.tarnyaginuug.ch@6wind.com, Nicolas Dichtel , davem@davemloft.net NLM_F_MULTI must be used only when a NLMSG_DONE message is sent. In fact, it is sent only at the end of a dump. Libraries like libnl will wait forever for NLMSG_DONE. Fixes: 37a393bc4932 ("bridge: notify mdb changes via netlink") CC: Cong Wang CC: Stephen Hemminger CC: bridge@lists.linux-foundation.org Signed-off-by: Nicolas Dichtel --- net/bridge/br_mdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index 409608960899..e29ad70b3000 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -170,7 +170,7 @@ static int nlmsg_populate_mdb_fill(struct sk_buff *skb, struct br_port_msg *bpm; struct nlattr *nest, *nest2; - nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), NLM_F_MULTI); + nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), 0); if (!nlh) return -EMSGSIZE; -- 2.2.2