From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1466708400.1847.15.camel@perches.com> From: Joe Perches In-Reply-To: <20160623173659.GA3474@salvia> References: <20160623173659.GA3474@salvia> Content-Type: text/plain; charset="iso-8859-1" Date: Thu, 23 Jun 2016 12:00:00 -0700 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Bridge] [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pablo Neira Ayuso Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Patrick McHardy , coreteam@netfilter.org, netfilter-devel@vger.kernel.org, Jozsef Kadlecsik , "David S. Miller" On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote: > On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > >=20 > > There is code duplication of a masked ethernet address comparison here > > so make it a separate function instead. > >=20 > > Miscellanea: > >=20 > > o Neaten alignment of FWINV macro uses to make it clearer for the reader > Applied, thanks. >=20 > >=20 > > Signed-off-by: Joe Perches > > --- > >=20 > > This masked_ether_addr_equal function could go into etherdevice.h, > > but I don't see another use like it in kernel code.=A0=A0Is there one? > This is specific of iptables, not even nftables would use this. So I > would keep this in the iptables tree. Did you see the other patch that adds a generic ether_addr_equal_masked() and uses it in a few more files?