From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1499101648; x=1530637648; h=from:to:cc:subject:date:message-id:mime-version; bh=t8VFVmKrPIdJotZvRHa+Pcg1DH3DN+l1+YuQhk3ZmWM=; b=DzSVEcQA5lgxtH1BfaQFXFDVXpyffCl4/7xBfCsD8z1AaxAG44p/T7P/ b+GYQAc6xB3LwfLF+5zx1HibGyMNIurMQbsgXDZy22JSOR0cwzpa83CKT H4KSWZX0s5XuYV1+x6VFIEuyKe5gY5EJPfEoBuVLCG4nOamAOQNN58rCn U=; From: Eduardo Valentin Date: Mon, 3 Jul 2017 10:06:34 -0700 Message-ID: <1499101594-22421-1-git-send-email-eduval@amazon.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Bridge] [PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stephen Hemminger , "David S . Miller" Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, "stable # v4 . 9+" We currently get the following kmemleak report: unreferenced object 0xffff8800039d9820 (size 32): comm "softirq", pid 0, jiffies 4295212383 (age 792.416s) hex dump (first 32 bytes): 00 0c e0 03 00 88 ff ff ff 02 00 00 00 00 00 00 ................ 00 00 00 01 ff 11 00 02 86 dd 00 00 ff ff ff ff ................ backtrace: [] kmemleak_alloc+0x4a/0xa0 [] kmem_cache_alloc_trace+0xb8/0x1c0 [] __br_mdb_notify+0x2a3/0x300 [bridge] [] br_mdb_notify+0x6e/0x70 [bridge] [] br_multicast_add_group+0x109/0x150 [bridge] [] br_ip6_multicast_add_group+0x58/0x60 [bridge] [] br_multicast_rcv+0x1d5/0xdb0 [bridge] [] br_handle_frame_finish+0xcf/0x510 [bridge] [] br_nf_hook_thresh.part.27+0xb/0x10 [br_netfilter] [] br_nf_hook_thresh+0x48/0xb0 [br_netfilter] [] br_nf_pre_routing_finish_ipv6+0x109/0x1d0 [br_netfilter] [] br_nf_pre_routing_ipv6+0xd0/0x14c [br_netfilter] [] br_nf_pre_routing+0x197/0x3d0 [br_netfilter] [] nf_iterate+0x52/0x60 [] nf_hook_slow+0x5c/0xb0 [] br_handle_frame+0x1a4/0x2c0 [bridge] This patch flags the complete_info ptr object as not a leak as it will get freed when .complete_priv() is called, for the br mdb case, it will be freed at br_mdb_complete(). Cc: stable # v4.9+ Reviewed-by: Vallish Vaidyeshwara Signed-off-by: Eduardo Valentin --- net/bridge/br_mdb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index b084548..1c81546 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -5,6 +5,7 @@ #include #include #include +#include #include #include #include @@ -319,6 +320,8 @@ static void __br_mdb_notify(struct net_device *dev, struct net_bridge_port *p, if (port_dev && type == RTM_NEWMDB) { complete_info = kmalloc(sizeof(*complete_info), GFP_ATOMIC); if (complete_info) { + /* This pointer is freed in br_mdb_complete() */ + kmemleak_not_leak(complete_info); complete_info->port = p; __mdb_entry_to_br_ip(entry, &complete_info->ip); mdb.obj.complete_priv = complete_info; -- 2.7.4