Re: [Bridge] [PATCH net-next v2 03/12] net: macsec: use new function dev_fetch_sw_netstats

[Antoine Tenart <atenart@kernel.org>]

Hello,

Quoting Heiner Kallweit (2020-10-12 10:04:11)
> Simplify the code by using new function dev_fetch_sw_netstats().
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Antoine Tenart <atenart@kernel.org>

Thanks!
Antoine

> ---
>  drivers/net/macsec.c | 22 +---------------------
>  1 file changed, 1 insertion(+), 21 deletions(-)
> 
> diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
> index 2b0c8f01d..11ca5fa90 100644
> --- a/drivers/net/macsec.c
> +++ b/drivers/net/macsec.c
> @@ -3647,30 +3647,10 @@ static int macsec_change_mtu(struct net_device *dev, int new_mtu)
>  static void macsec_get_stats64(struct net_device *dev,
>                                struct rtnl_link_stats64 *s)
>  {
> -       int cpu;
> -
>         if (!dev->tstats)
>                 return;
>  
> -       for_each_possible_cpu(cpu) {
> -               struct pcpu_sw_netstats *stats;
> -               struct pcpu_sw_netstats tmp;
> -               int start;
> -
> -               stats = per_cpu_ptr(dev->tstats, cpu);
> -               do {
> -                       start = u64_stats_fetch_begin_irq(&stats->syncp);
> -                       tmp.rx_packets = stats->rx_packets;
> -                       tmp.rx_bytes   = stats->rx_bytes;
> -                       tmp.tx_packets = stats->tx_packets;
> -                       tmp.tx_bytes   = stats->tx_bytes;
> -               } while (u64_stats_fetch_retry_irq(&stats->syncp, start));
> -
> -               s->rx_packets += tmp.rx_packets;
> -               s->rx_bytes   += tmp.rx_bytes;
> -               s->tx_packets += tmp.tx_packets;
> -               s->tx_bytes   += tmp.tx_bytes;
> -       }
> +       dev_fetch_sw_netstats(s, dev->tstats);
>  
>         s->rx_dropped = dev->stats.rx_dropped;
>         s->tx_dropped = dev->stats.tx_dropped;
> -- 
> 2.28.0
> 
>