From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628026806; bh=HSjp7yTfMWSo9/m1hJfmmC8BGuirWnw6EQI7FTh6pEs=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=mOB5Q5w+z/9ybQugkcsUY8cOW0Z1G/NW4j2vNzu3XQYLBtOHk985RWvmuruHyg97D wsMN/qvlC6jhTngfO9ZTtfP182PVQyAIIHcoD0K6Vj10ryexoVT1BvZa3Ur8FeZ2FL nu3QqFvSnR3C+G+QtUHVZUCJoVxWpIK+yZUU+/SgMZhkn9sYS1j4DWHb3/H27cYUSZ FeLDOezR0epEQDEEmz0pB3cdJ1oiDxAJsahd0iXJbpYVKc3jlwivTwh08qWNG94xHb JOAv5smT3ohBrL1P25oq5oyDfuUZkTjqyfYL8vXT7W968kOXHbeJNFASAf955ObFVB zDW6zef5SFRvg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <162802680646.18812.7948023061004183994.git-patchwork-notify@kernel.org> Date: Tue, 03 Aug 2021 21:40:06 +0000 References: <20210802113633.189831-1-vladimir.oltean@nxp.com> In-Reply-To: <20210802113633.189831-1-vladimir.oltean@nxp.com> Subject: Re: [Bridge] [PATCH net-next] net: bridge: switchdev: fix incorrect use of FDB flags when picking the dst device List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Oltean Cc: jiri@resnulli.us, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, idosch@idosch.org, nikolay@nvidia.com, roopa@nvidia.com, kuba@kernel.org, davem@davemloft.net Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 2 Aug 2021 14:36:33 +0300 you wrote: > Nikolay points out that it is incorrect to assume that it is impossible > to have an fdb entry with fdb->dst == NULL and the BR_FDB_LOCAL bit in > fdb->flags not set. This is because there are reader-side places that > test_bit(BR_FDB_LOCAL, &fdb->flags) without the br->hash_lock, and if > the updating of the FDB entry happens on another CPU, there are no > memory barriers at writer or reader side which would ensure that the > reader sees the updates to both fdb->flags and fdb->dst in the same > order, i.e. the reader will not see an inconsistent FDB entry. > > [...] Here is the summary with links: - [net-next] net: bridge: switchdev: fix incorrect use of FDB flags when picking the dst device https://git.kernel.org/netdev/net-next/c/2e19bb35ce15 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html