From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zL3zAyFVSY3b9tOnPyfU+7HZbn2fwn34DVHclMTOxIM=; b=LrsaqLT1q3SQ0uASZlNpLZwn2OT10CWeUnsTzofQWIG4W4bfOEmT13Q91UpjOLMq7s lrpBPBf94SI7EbFNxbrX+Z/FunV8lwcQwOa8PswQHuORAvup4TEAo9xf7hVSakwwOPnA GuyV9BEc3s+TJiupOCo9LTsOKC9C6/h//ZfyR20aJ+FFVWNNnmWzPtf364WCXaoPaiM5 lJvrTGrUjdYY83vBcra2zXLR6P5SmQ0YLe3A8WGIcfxftiwix3egfw7A3/HPPdM1/fDx ZBTN1+CxT+TbhNO/G/yP80ZMrIydOgwnA8vEQlWD/vnscKXAi3LFneb72yKNQ2XFhKBZ 2N3g== Message-ID: <1efd4c00-4c78-2330-cfb3-fe81493e7e68@gmail.com> Date: Mon, 25 Apr 2022 13:47:21 +0200 MIME-Version: 1.0 Content-Language: en-US References: <7c8367b6-95c7-ea39-fafe-72495f343625@blackwall.org> <4bf69eef-7444-1238-0f4a-fb0fccda080c@blackwall.org> <3bcb2d3d-8b8b-8a8f-1285-7277394b4e6b@gmail.com> <0f1e1250-920a-c7d1-900c-98ef3e0456d8@blackwall.org> From: Alaa Mohamed In-Reply-To: <0f1e1250-920a-c7d1-900c-98ef3e0456d8@blackwall.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Subject: Re: [Bridge] [PATCH net-next v3 1/2] rtnetlink: add extack support in fdb del handlers List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikolay Aleksandrov , netdev@vger.kernel.org Cc: shshaikh@marvell.com, jdenham@redhat.com, GR-Linux-NIC-Dev@marvell.com, manishc@marvell.com, alexandre.belloni@bootlin.com, outreachy@lists.linux.dev, vladimir.oltean@nxp.com, bridge@lists.linux-foundation.org, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, sbrivio@redhat.com, claudiu.manoil@nxp.com, anthony.l.nguyen@intel.com, roopa@nvidia.com, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net, UNGLinuxDriver@microchip.com, intel-wired-lan@lists.osuosl.org On ٢٤‏/٤‏/٢٠٢٢ ٢٣:٥٢, Nikolay Aleksandrov wrote: > On 4/25/22 00:09, Alaa Mohamed wrote: >> >> On ٢٤‏/٤‏/٢٠٢٢ ٢١:٥٥, Nikolay Aleksandrov wrote: >>> On 24/04/2022 22:49, Alaa Mohamed wrote: >>>> On ٢٤‏/٤‏/٢٠٢٢ ٢١:٠٢, Nikolay Aleksandrov wrote: >>>>> On 24/04/2022 15:09, Alaa Mohamed wrote: >>>>>> Add extack support to .ndo_fdb_del in netdevice.h and >>>>>> all related methods. >>>>>> >>>>>> Signed-off-by: Alaa Mohamed >>>>>> --- >>>>>> changes in V3: >>>>>>           fix errors reported by checkpatch.pl >>>>>> --- >>>>>>    drivers/net/ethernet/intel/ice/ice_main.c        | 4 ++-- >>>>>>    drivers/net/ethernet/mscc/ocelot_net.c           | 4 ++-- >>>>>>    drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 +- >>>>>>    drivers/net/macvlan.c                            | 2 +- >>>>>>    drivers/net/vxlan/vxlan_core.c                   | 2 +- >>>>>>    include/linux/netdevice.h                        | 2 +- >>>>>>    net/bridge/br_fdb.c                              | 2 +- >>>>>>    net/bridge/br_private.h                          | 2 +- >>>>>>    net/core/rtnetlink.c                             | 4 ++-- >>>>>>    9 files changed, 12 insertions(+), 12 deletions(-) >>>>>> >>>>>> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c >>>>>> b/drivers/net/ethernet/intel/ice/ice_main.c >>>>>> index d768925785ca..7b55d8d94803 100644 >>>>>> --- a/drivers/net/ethernet/intel/ice/ice_main.c >>>>>> +++ b/drivers/net/ethernet/intel/ice/ice_main.c >>>>>> @@ -5678,10 +5678,10 @@ ice_fdb_add(struct ndmsg *ndm, struct >>>>>> nlattr __always_unused *tb[], >>>>>>    static int >>>>>>    ice_fdb_del(struct ndmsg *ndm, __always_unused struct nlattr >>>>>> *tb[], >>>>>>            struct net_device *dev, const unsigned char *addr, >>>>>> -        __always_unused u16 vid) >>>>>> +        __always_unused u16 vid, struct netlink_ext_ack *extack) >>>>>>    { >>>>>>        int err; >>>>>> - >>>>>> + >>>>> What's changed here? >>>> In the previous version, I removed the blank line after "int err;" >>>> and you said I shouldn't so I added blank line. >>>> >>> Yeah, my question is are you fixing a dos ending or something else? >>> The blank line is already there, what's wrong with it? >> No, I didn't. >>> >>> The point is it's not nice to mix style fixes and other changes, >>> more so >>> if nothing is mentioned in the commit message. >> Got it, So, what should I do to fix it? > > Don't change that line? I mean I'm even surprised this made it in the > patch. As I mentioned above, there is already a new line there so I'm > not sure how you're removing it and adding it again. :) > > Cheers, >  Nik Thanks Nik, I will fix this.