From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8682C8201F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org BF6DA81FDA MIME-Version: 1.0 Date: Thu, 02 Feb 2023 18:18:10 +0100 From: netdev@kapio-technology.com In-Reply-To: References: <20230130173429.3577450-1-netdev@kapio-technology.com> Message-ID: <1fe06ed3010fe318728ebd73eee7f092@kapio-technology.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next 0/5] ATU and FDB synchronization on locked ports List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ido Schimmel Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , Ivan Vecera , Florian Fainelli , "moderated list:ETHERNET BRIDGE" , Russell King , Roopa Prabhu , kuba@kernel.org, Paolo Abeni , =?UTF-8?Q?Cl=C3=A9m?= =?UTF-8?Q?ent_L=C3=A9ger?= , Christian Marangi , Woojung Huh , Landen Chao , Jiri Pirko , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , netdev@vger.kernel.org, open list , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , Vladimir Oltean , davem@davemloft.net On 2023-01-31 20:25, Ido Schimmel wrote: >> command like: >> >> bridge fdb replace ADDR dev master dynamic >> >> We choose only to support this feature on locked ports, as it involves >> utilizing the CPU to handle ATU related switchcore events (typically >> interrupts) and thus can result in significant performance loss if >> exposed to heavy traffic. > > Not sure I understand this reasoning. I was under the impression that > hostapd is installing dynamic entries instead of static ones since the > latter are not flushed when carrier is lost. Therefore, with static > entries it is possible to unplug a host (potentially plugging a > different one) and not lose authentication. > Both auth schemes 802.1X and MAB install dynamic entries as you point out, and both use locked ports. In the case of non locked ports, they just learn normally and age and refresh their entries, so the use case of a userspace added dynamic FDB entry is hard for me to see. And having userspace being notified of an ordinary event that a FDB entry has been aged out could maybe be used, but for the reasons mentioned it is not supported here. >> >> On locked ports it is important for userspace to know when an >> authorized >> station has become silent, hence not breaking the communication of a >> station that has been authorized based on the MAC-Authentication >> Bypass >> (MAB) scheme. Thus if the station keeps being active after >> authorization, >> it will continue to have an open port as long as it is active. Only >> after >> a silent period will it have to be reauthorized. As the ageing process >> in >> the ATU is dependent on incoming traffic to the switchcore port, it is >> necessary for the ATU to signal that an entry has aged out, so that >> the >> FDB can be updated at the correct time. > > Why mention MAB at all? Don't you want user space to always use dynamic > entries to authenticate hosts regardless of 802.1X/MAB? Yes, you are right about that. I guess it came about as this was developed much in the same time and with the code of MAB.