Ethernet Bridge development
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: "David S.Miller" <davem@redhat.com>,
	netdev@oss.sgi.com, Ben Greear <greearb@candelatech.com>,
	bridge <bridge@osdl.org>,
	vlan@wanfear.com
Subject: [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I,AR}P packets
Date: Tue, 7 Oct 2003 08:52:41 -0700	[thread overview]
Message-ID: <20031007085241.7410611a.shemminger@osdl.org> (raw)
In-Reply-To: <200310062204.07230.bdschuym@pandora.be>

Instead of using vlan_dev_hard_start_xmit_p which causes looking
too deep inside vlan, use the fact that all bridges and vlan devices
are marked with dev->priv_flags.

Instead of:

#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
	    || (out->hard_start_xmit == vlan_dev_hard_start_xmit_p &&
	    VLAN_DEV_INFO(out)->real_dev->hard_start_xmit == br_dev_xmit
#endif

Try:

#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
	    || (out->priv_flags & IFF_802_1Q_VLAN) &&
	    (VLAN_DEV_INFO(out)->real_dev->priv_vlags & IFF_EBRIDGE)
#endif


Gets rid of all the symbol export and other nastiness

      parent reply	other threads:[~2003-10-07 15:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-06 20:04 [Bridge] [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets Bart De Schuymer
2003-10-06 20:19 ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I,AR}P packets Stephen Hemminger
2003-10-06 20:55   ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets Bart De Schuymer
2003-10-06 20:24 ` Ben Greear
2003-10-06 20:58   ` Bart De Schuymer
2003-10-07 15:06 ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I,AR}P packets David S. Miller
2003-10-07 19:12   ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets Bart De Schuymer
2003-10-07 19:12     ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I,AR}P packets David S. Miller
2003-10-07 20:22     ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets Stephen Hemminger
2003-10-07 15:52 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031007085241.7410611a.shemminger@osdl.org \
    --to=shemminger@osdl.org \
    --cc=bdschuym@pandora.be \
    --cc=bridge@osdl.org \
    --cc=davem@redhat.com \
    --cc=greearb@candelatech.com \
    --cc=netdev@oss.sgi.com \
    --cc=vlan@wanfear.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox