Ethernet Bridge development
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: fulvio.ricciardi@zeroshell.net
Cc: bridge@lists.osdl.org
Subject: Re: [Bridge] Passing vlan tagged packets through linux bridge
Date: Fri, 1 Dec 2006 10:29:24 -0800	[thread overview]
Message-ID: <20061201102924.7e1045d2@freekitty> (raw)
In-Reply-To: <457061ba.3a6.7c77.1170958095@webmailh3.aruba.it>

On Fri, 01 Dec 2006 18:09:14 +0100
"Fulvio Ricciardi" <fulvio.ricciardi@zeroshell.net> wrote:

> > Use an Intel pro/100 or pro/1000 driver..they are known to
> > work with VLANs.
> > 
> > I guess it's also possible that it's a problem in the
> > bridging code, so  try the latest kernel
> > as well...
> 
> I compiled the latest 2.6.19 kernel and tested it with two
> 3COM 3c905c fast ethernet interfaces which work fine with
> vlan 802.1q tagging, but when I have added the eth0 and eth1
> to br0 the bridge doesn't forward tagged packets larger than
> 1472 bytes. I remember that with older kernels (<2.6.15)
> large tagged packets was forwarded. 
> What is the problem? Any chance to have a patch?
> Thanks in advance for your answers.
>  Best Regards
>    Fulvio Ricciardi
> 


This code might be dropping it, but don't see why because it
is already checking for VLAN

net/bridge/br_forward.c

static inline unsigned packet_length(const struct sk_buff *skb)
{
	return skb->len - (skb->protocol == htons(ETH_P_8021Q) ? VLAN_HLEN : 0);
}

int br_dev_queue_push_xmit(struct sk_buff *skb)
{
	/* drop mtu oversized packets except gso */
	if (packet_length(skb) > skb->dev->mtu && !skb_is_gso(skb))
		kfree_skb(skb);

-- 
Stephen Hemminger <shemminger@osdl.org>

  reply	other threads:[~2006-12-01 18:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-01 17:09 [Bridge] Passing vlan tagged packets through linux bridge Fulvio Ricciardi
2006-12-01 18:29 ` Stephen Hemminger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-12-01 21:19 Fulvio Ricciardi
2006-11-27 19:12 Fulvio Ricciardi
2006-11-26  6:04 kasra kangavari
2006-11-27 12:31 ` Lutz Jaenicke
2006-11-25 15:22 Fulvio Ricciardi
2006-11-25 16:13 ` Roman Chertov
2006-11-25 12:12 Fulvio Ricciardi
2006-11-27 17:59 ` Ben Greear
2006-11-25  7:44 kasra kangavari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061201102924.7e1045d2@freekitty \
    --to=shemminger@osdl.org \
    --cc=bridge@lists.osdl.org \
    --cc=fulvio.ricciardi@zeroshell.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox