From: Francesco Dolcini <fdolcini@sysnetsistemi.it>
To: bridge@lists.linux-foundation.org
Subject: [Bridge] [PATCH] stp timer fix, linux version 2.4
Date: Tue, 9 Oct 2007 16:28:50 +0200 [thread overview]
Message-ID: <20071009142850.GA29180@fd.sysnet.local> (raw)
In kernel 2.4, br_record_config_information update message_age_timer
with jiffies in the past. In 2.6 is already fixed and a similar fix
appeared in v2.4.35.3.
sorry if you receive this twice, I had problem sending to the list (I
think my previous mail got filtered)
Signed-off-by: Francesco Dolcini <fdolcini@sysnetsistemi.it>
--- /a/net/bridge/br_stp.c
+++ /b/net/bridge/br_stp.c
@@ -186,9 +186,11 @@
p->designated_cost = bpdu->root_path_cost;
p->designated_bridge = bpdu->bridge_id;
p->designated_port = bpdu->port_id;
- br_timer_set(&p->message_age_timer, jiffies - bpdu->message_age);
+ br_timer_set(&p->message_age_timer, jiffies +
+ (p->br->max_age - bpdu->message_age));
+
}
/* called under bridge lock */
static void br_record_config_timeout_values(struct net_bridge *br, struct br_config_bpdu *bpdu)
next reply other threads:[~2007-10-09 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 14:28 Francesco Dolcini [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-09 12:57 [Bridge] [PATCH] stp timer fix, linux version 2.4 Francesco Dolcini
2007-10-10 14:47 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009142850.GA29180@fd.sysnet.local \
--to=fdolcini@sysnetsistemi.it \
--cc=bridge@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox