Ethernet Bridge development
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Jaime Medrano <jaime.medrano@gmail.com>
Cc: bridge@lists.osdl.org
Subject: Re: [Bridge] [PATCH] Add vlan id to bridge forward database
Date: Mon, 17 Dec 2007 08:53:49 -0800	[thread overview]
Message-ID: <20071217085349.729e5c17@deepthought> (raw)
In-Reply-To: <4766a3d1.02ab100a.0be8.6fdc@mx.google.com>

On Mon, 17 Dec 2007 17:13:09 +0100
Jaime Medrano <jaime.medrano@gmail.com> wrote:

> Hi!
> 
> This makes forwarding table aware of 802.1Q vlan ids and stores
> id with MACs in the table.
> 
> It solves problems when having same MAC on diffent pairs
> (vlan, port). Current code gets confused at that situation.
> 
> Local MACs are managed as present on every vlan.
> 
> Signed-off-by: Jaime Medrano <jaime.medrano@gmail.com>

What about the nested vlan case?

I assume it continues to work without Vlan's.
How does this affect use of the userspace RSTP?


> --- linux-2.6.23.orig/include/linux/if_bridge.h	2007-12-17 11:59:46.000000000 +0100
> +++ linux-2.6.23/include/linux/if_bridge.h	2007-12-17 12:00:28.000000000 +0100
> @@ -97,7 +97,8 @@
>  	__u8 port_no;
>  	__u8 is_local;
>  	__u32 ageing_timer_value;
> -	__u32 unused;
> +	__u16 vlan_id;
> +	__u16 unused;
>  };

This is a user/kernel ABI change. Does it break old tools?


-- 
Stephen Hemminger <shemminger@linux-foundation.org>

  reply	other threads:[~2007-12-17 16:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17 16:13 [Bridge] [PATCH] Add vlan id to bridge forward database Jaime Medrano
2007-12-17 16:53 ` Stephen Hemminger [this message]
2007-12-18  9:05   ` Jaime Medrano
2008-01-28 15:39   ` Jaime Medrano
2008-01-28 20:29     ` [Bridge] " Benny Amorsen
2008-03-17 18:35     ` [Bridge] " Stephen Hemminger
2008-04-02  9:30       ` Jaime Medrano
2008-04-28 20:57     ` Stephen Hemminger
2008-04-29  8:24       ` Jaime Medrano
2008-04-29 12:43         ` Benny Amorsen
2008-04-29 15:18           ` Jaime Medrano
2008-04-29 23:16         ` richardvoigt
2008-04-30  2:25           ` Jonathan Thibault
  -- strict thread matches above, loose matches on Subject: below --
2007-12-17 16:13 Jaime Medrano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071217085349.729e5c17@deepthought \
    --to=shemminger@linux-foundation.org \
    --cc=bridge@lists.osdl.org \
    --cc=jaime.medrano@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox