From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 9 Jul 2009 12:55:21 -0700 From: Stephen Hemminger Message-ID: <20090709125521.4bacfd47@nehalam> In-Reply-To: <20090704062321.034802084@openvz.org> References: <20090704061156.658235360@openvz.org> <20090704062321.034802084@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [patch 2/2] net, netns_xt: shrink netns_xt members List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov Cc: Cyrill Gorcunov , netdev@vger.kernel.org, bridge@lists.linux-foundation.org On Sat, 04 Jul 2009 10:11:58 +0400 Cyrill Gorcunov wrote: > In case if kernel was compiled without ebtables support > there is no need to keep ebt_table pointers in netns_xt > structure. > > Make it config dependent. > > Signed-off-by: Cyrill Gorcunov > --- > > Probably GCC will authomatically shrink the structure > if the members are not in use. Please review. > > include/net/netns/x_tables.h | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux-2.6.git/include/net/netns/x_tables.h > ===================================================================== > --- linux-2.6.git.orig/include/net/netns/x_tables.h > +++ linux-2.6.git/include/net/netns/x_tables.h > @@ -8,8 +8,11 @@ struct ebt_table; > > struct netns_xt { > struct list_head tables[NFPROTO_NUMPROTO]; > +#if defined(CONFIG_BRIDGE_NF_EBTABLES) || \ > + defined(CONFIG_BRIDGE_NF_EBTABLES_MODULE) > struct ebt_table *broute_table; > struct ebt_table *frame_filter; > struct ebt_table *frame_nat; > +#endif > }; > #endif > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Stephen Hemminger --