From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Thu, 19 Nov 2009 12:44:43 +0100 References: <1258497551-25959-1-git-send-email-arnd@arndb.de> <200911182332.56309.arnd@arndb.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200911191244.43916.arnd@arndb.de> Subject: Re: [Bridge] [PATCH 1/3] macvlan: Reflect macvlan packets meant for other macvlan devices List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Eric W. Biederman" Cc: virtualization@linux-foundation.com, Herbert Xu , Eric Dumazet , Anna Fischer , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Gerhard Stenzel , Jens Osterkamp , Patrick Mullaney , Stephen Hemminger , Edge Virtual Bridging , David Miller On Thursday 19 November 2009, Eric W. Biederman wrote: > > It seems that we should never drop dst then. We either forward the frame to > > netif_rx or to dev_queue_xmit, and from how I read it now, we want to keep > > the dst in both cases. > > When we loop back on our selves we certainly need to have dst clear because > we don't know how to cache routes through multiple network namespaces. Ah, right. So should I add the explicit dst_drop to the new dev_forward_skb() then? The veth driver doesn't need it, but it also looks like it won't hurt. Arnd <><