Ethernet Bridge development
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Yavetskiy Yuriy <yavetskiy@kpi.ua>
Cc: bridge@lists.linux-foundation.org
Subject: Re: [Bridge] Re :Re: Re :Re: Re :Re: Bridging LACP (802.3ad)	frames not working
Date: Wed, 20 Jan 2010 09:54:53 -0800	[thread overview]
Message-ID: <20100120095453.09546783@nehalam> (raw)
In-Reply-To: <4B572FCA.8080905@kpi.ua>

On Wed, 20 Jan 2010 18:31:06 +0200
Yavetskiy Yuriy <yavetskiy@kpi.ua> wrote:

> Hello.
> 
> I solve my problem without ebtables.
> Just add to net/bridge/br_input.c next strings (with +):
> 
>         if (unlikely(is_link_local(dest))) {
>                 /* Pause frames shouldn't be passed up by driver anyway */
>                 if (skb->protocol == htons(ETH_P_PAUSE))
>                         goto drop;
> 
> +                /* Don't touch SLOW frames (LACP, etc.) */
> +               if (skb->protocol == htons(ETH_P_SLOW))
> +                        goto forward;
> 

Fine for your case, but in general it is wrong to forward these
frames. 


-- 

  reply	other threads:[~2010-01-20 17:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-19 19:44 [Bridge] Re :Re: Re :Re: Re :Re: Bridging LACP (802.3ad) frames not working yavetskiy
2010-01-20 16:31 ` Yavetskiy Yuriy
2010-01-20 17:54   ` Stephen Hemminger [this message]
2010-01-20 18:14     ` Jean-Michel Hautbois
2010-03-18  9:06       ` Phil Karn
  -- strict thread matches above, loose matches on Subject: below --
2010-01-13 16:53 Jean-Michel Hautbois
2010-01-13 16:55 ` Stephen Hemminger
2010-01-13 17:21   ` Jean-Michel Hautbois
2010-01-13 17:42     ` Jean-Michel Hautbois
2010-01-13 16:30 [Bridge] " Stephen Hemminger
2010-01-13 16:47 ` [Bridge] Re :Re: " jhautbois
2010-01-13 16:49   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100120095453.09546783@nehalam \
    --to=shemminger@linux-foundation.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=yavetskiy@kpi.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox