From: Rodolfo Giometti <giometti@enneenne.com>
To: bridge@lists.linux-foundation.org
Subject: [Bridge] Invalid BPDU transmission?
Date: Tue, 5 Oct 2010 11:54:58 +0200 [thread overview]
Message-ID: <20101005095458.GB2584@enneenne.com> (raw)
Hello,
in function STP_transmit_check_conditions (rstplib/transmit.c) the
case:
case IDLE:
if (!port->helloWhen) return STP_hop_2_state (this,
TRANSMIT_PERIODIC);
if (!port->sendRSTP && port->newInfo &&
(port->txCount < TxHoldCount) &&
(port->role == DesignatedPort) &&
port->helloWhen)
return STP_hop_2_state (this, TRANSMIT_CONFIG);
if (!port->sendRSTP && port->newInfo &&
(port->txCount < TxHoldCount) &&
(port->role == RootPort) &&
port->helloWhen)
return STP_hop_2_state (this, TRANSMIT_TCN);
if (port->sendRSTP && port->newInfo &&
(port->txCount < TxHoldCount) &&
((port->role == RootPort) || <----
(port->role == DesignatedPort)))
return STP_hop_2_state (this, TRANSMIT_RSTP);
break;
states that a RSTP bpdu can be transmitted even throught a RootPort
which, IMHO, is not correct... only topology change BPDU should be
sent over the RootPort. That's why I suggest to remove the line with
the arrow (<----).
Comments? :)
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
next reply other threads:[~2010-10-05 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 9:54 Rodolfo Giometti [this message]
2010-10-05 12:40 ` [Bridge] Invalid BPDU transmission? Srinivas M.A.
2010-10-06 15:32 ` Rodolfo Giometti
2010-10-06 16:20 ` Rodolfo Giometti
2010-10-06 21:51 ` Srinivas M.A.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005095458.GB2584@enneenne.com \
--to=giometti@enneenne.com \
--cc=bridge@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox