From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 10 Dec 2010 23:52:27 +0100 From: Tobias Klauser Message-ID: <20101210225226.GL10190@distanz.ch> References: <20101209082924.6d797871@nehalam> <1291903356-30618-1-git-send-email-tklauser@distanz.ch> <1291987084-27302-1-git-send-email-tklauser@distanz.ch> <20101210.130125.233714141.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101210.130125.233714141.davem@davemloft.net> Subject: Re: [Bridge] [PATCH v2] bridge: Fix return values of br_multicast_add_group/br_multicast_new_group List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Miller Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org On 2010-12-10 at 22:01:25 +0100, David Miller wrote: > From: Tobias Klauser > Date: Fri, 10 Dec 2010 14:18:04 +0100 > > > If br_multicast_new_group returns NULL, we would return 0 (no error) to > > the caller of br_multicast_add_group, which is not what we want. Instead > > br_multicast_new_group should return ERR_PTR(-ENOMEM) in this case. > > Also propagate the error number returned by br_mdb_rehash properly. > > > > Signed-off-by: Tobias Klauser > > Looks good, applied to net-next-2.6 > > Please in the future make is clear, in your subject line, which > tree this patch is meant for. > > I had to figure it out by trial and error, because this patch > does not apply properly to net-2.6 Sorry about that. I'll do so in the future. Thanks