From: Stephen Hemminger <shemminger@vyatta.com>
To: Dongdong Deng <dongdong.deng@windriver.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH] bridge: return value for br_stp_recalculate_bridge_id()
Date: Tue, 29 Mar 2011 23:27:22 -0700 [thread overview]
Message-ID: <20110329232722.31357223@s6510> (raw)
In-Reply-To: <1301466207-16770-1-git-send-email-dongdong.deng@windriver.com>
On Wed, 30 Mar 2011 14:23:27 +0800
Dongdong Deng <dongdong.deng@windriver.com> wrote:
> Return 'false' for "user has set a mac addr" case in
> br_stp_recalculate_bridge_id() function.
>
> and this could address the following build warning:
>
> net/bridge/br_stp_if.c: In function br_stp_recalculate_bridge_id:
> net/bridge/br_stp_if.c:216: warning: return with no value, in function
> returning non-void
>
> Signed-off-by: Dongdong Deng <dongdong.deng@windriver.com>
Patch has already been submitted and acke'd for this.
next prev parent reply other threads:[~2011-03-30 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 6:23 [Bridge] [PATCH] bridge: return value for br_stp_recalculate_bridge_id() Dongdong Deng
2011-03-30 6:27 ` Stephen Hemminger [this message]
2011-03-31 17:38 ` Stephen Hemminger
2011-03-31 22:31 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329232722.31357223@s6510 \
--to=shemminger@vyatta.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dongdong.deng@windriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).