From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: David Miller <davem@davemloft.net>
Cc: pekkas@netcore.fi, eric.dumazet@gmail.com,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, jmorris@namei.org,
bhutchings@solarflare.com, kuznet@ms2.inr.ac.ru,
therbert@google.com
Subject: Re: [Bridge] [RFC PATCH] net: fold dev_disable_lro() into netdev_fix_features()
Date: Thu, 12 May 2011 18:06:21 +0200 [thread overview]
Message-ID: <20110512160621.GA6588@rere.qmqm.pl> (raw)
In-Reply-To: <20110509.120811.246541047.davem@davemloft.net>
On Mon, May 09, 2011 at 12:08:11PM -0700, David Miller wrote:
> From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Date: Sat, 7 May 2011 13:48:02 +0200 (CEST)
> > This moves checks that device is forwarding from bridge, IPv4 and IPv6
> > code into netdev_fix_features(). As a side effect, after device is no longer
> > forwarding it gets LRO back. This also means that user is not allowed to
> > enable LRO after device is put to forwarding mode.
> We need to keep the check in the protocols because we don't want to
> be testing protocol specific device state in generic code like
> net/core/dev.c
I modified it to use priv_flags that mirror the protocol-internal state.
Patch follows.
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2011-05-12 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 11:48 [Bridge] [RFC PATCH] net: fold dev_disable_lro() into netdev_fix_features() Michał Mirosław
2011-05-09 19:08 ` David Miller
2011-05-12 16:06 ` Michał Mirosław [this message]
2011-05-12 16:06 ` [Bridge] [RFC PATCH v2] " Michał Mirosław
2011-05-12 16:29 ` Ben Hutchings
2011-05-12 16:35 ` Michał Mirosław
2011-05-12 16:57 ` Stephen Hemminger
2011-05-12 16:37 ` [Bridge] [RFC PATCH v3] " Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512160621.GA6588@rere.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=bhutchings@solarflare.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=therbert@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox