From: Noah Meyerhans <noahm@debian.org>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: 625914@bugs.debian.org, bridge@lists.linux-foundation.org,
Ben Hutchings <ben@decadent.org.uk>,
netdev <netdev@vger.kernel.org>
Subject: Re: [Bridge] Bug#625914: linux-image-2.6.38-2-amd64: bridging is not interacting well with multicast in 2.6.38-4
Date: Thu, 12 May 2011 22:03:02 -0700 [thread overview]
Message-ID: <20110513050302.GR6397@morgul.net> (raw)
In-Reply-To: <20110512164322.45626683@nehalam>
[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]
On Thu, May 12, 2011 at 04:43:22PM -0700, Stephen Hemminger wrote:
> > > There were two more follow on commits in stable related to this.
> > > I recommend merging 2.6.38.6 which includes these.
> >
> > The problem still exists in the current 2.6.38.6. Backing out 5f1c356a
> > still solves the problem there.
> >
> > I have not yet tried anything outside the stable-2.6.38.y tree, but it
> > seems like these same changes are present there, and it's unlikely that
> > other releases will work any better.
>
> Does this fix the problem? The tap driver allocates an skb and throws
> it into the receive path, but the skb does not have the same padding
> as normal skb's received.
>
> --- a/drivers/net/tun.c 2011-05-12 16:36:15.231347935 -0700
> +++ b/drivers/net/tun.c 2011-05-12 16:36:38.503464573 -0700
> @@ -614,7 +614,7 @@ static __inline__ ssize_t tun_get_user(s
> }
>
> if ((tun->flags & TUN_TYPE_MASK) == TUN_TAP_DEV) {
> - align = NET_IP_ALIGN;
> + align = NET_IP_ALIGN + NET_SKB_PAD;
> if (unlikely(len < ETH_HLEN ||
> (gso.hdr_len && gso.hdr_len < ETH_HLEN)))
> return -EINVAL;
>
Sorry, this does not fix the problem.
noah
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2011-05-13 5:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110506201234.6297.70279.reportbug@ip6-localhost>
2011-05-10 2:38 ` [Bridge] Bug#625914: linux-image-2.6.38-2-amd64: bridging is not interacting well with multicast in 2.6.38-4 Ben Hutchings
2011-05-10 3:15 ` Stephen Hemminger
2011-05-10 4:38 ` Noah Meyerhans
2011-05-10 12:42 ` Ben Hutchings
2011-05-10 18:05 ` Noah Meyerhans
2011-05-10 22:11 ` Stephen Hemminger
2011-05-10 23:35 ` Noah Meyerhans
2011-05-12 22:59 ` David Miller
2011-05-12 23:28 ` Stephen Hemminger
2011-05-12 23:43 ` Stephen Hemminger
2011-05-13 5:03 ` Noah Meyerhans [this message]
2011-05-13 18:03 ` Stephen Hemminger
2011-05-13 19:53 ` [Bridge] [PATCH] bridge: fix forwarding of IPv6 Stephen Hemminger
2011-05-13 20:00 ` Eric Dumazet
2011-05-13 20:02 ` David Miller
2011-05-13 20:05 ` Eric Dumazet
2011-05-13 20:24 ` Stephen Hemminger
2011-05-13 20:03 ` David Miller
2011-05-13 21:00 ` Noah Meyerhans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110513050302.GR6397@morgul.net \
--to=noahm@debian.org \
--cc=625914@bugs.debian.org \
--cc=ben@decadent.org.uk \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).