From: David Lamparter <equinox@diac24.net>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
Alexander Stein <alexander.stein@systec-electronic.com>
Subject: Re: [Bridge] possible bridge regression in "bridge: implement [add/del]_slave ops"?
Date: Fri, 1 Jul 2011 12:08:33 +0200 [thread overview]
Message-ID: <20110701100833.GA3988422@jupiter.n2.diac24.net> (raw)
In-Reply-To: <20110630100819.0e4b536f@nehalam.ftrdhcpuser.net>
On Thu, Jun 30, 2011 at 10:08:19AM -0700, Stephen Hemminger wrote:
> On Thu, 30 Jun 2011 10:33:23 +0200
> Alexander Stein <alexander.stein@systec-electronic.com> wrote:
>
> > * echo $(pgrep rstpd) > /var/run/rstpd.pid
> > * brctl addbr br1
> > * echo 1 > /sys/class/net/br1/bridge/stp_state
>
> This bogus. You are running both kernel and spanning
> tree daemon at the same time!
>
> Doing the echo of 1 to stp_state forces kernel spanning
> tree. You want 2 which is what is supposed to be use for user
> mode spanning tree.
I just tested this on my box, you can't echo 2 into that sysfs file (it
reads back as 1).
That you can change this variable at all when an userspace stp
implementation is running is a bug anyway, IMHO. rstpd should do all the
required settings and the kernel should prevent them from being changed
while rstpd has the bridge under its control.
-David
next prev parent reply other threads:[~2011-07-01 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 8:33 [Bridge] possible bridge regression in "bridge: implement [add/del]_slave ops"? Alexander Stein
[not found] ` <201106301527.19539.alexander.stein@systec-electronic.com>
2011-06-30 17:03 ` Stephen Hemminger
2011-06-30 17:08 ` Stephen Hemminger
2011-07-01 10:08 ` David Lamparter [this message]
2011-07-04 6:46 ` Alexander Stein
2011-07-05 21:28 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2011-08-10 7:54 Weirich, Bernhard
2011-08-10 15:11 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701100833.GA3988422@jupiter.n2.diac24.net \
--to=equinox@diac24.net \
--cc=alexander.stein@systec-electronic.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox