From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 4 Nov 2012 08:55:55 +0100 From: Lee Jones Message-ID: <20121104075555.GB24262@gmail.com> References: <1351980150-24145-1-git-send-email-lee.jones@linaro.org> <1351980150-24145-10-git-send-email-lee.jones@linaro.org> <20121104.010043.1842614952525101679.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20121104.010043.1842614952525101679.davem@davemloft.net> Subject: Re: [Bridge] [PATCH 9/9] Avoid 'statement with no effect' compiler warnings List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Miller Cc: netdev@vger.kernel.org, shemminger@vyatta.com, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org On Sun, 04 Nov 2012, David Miller wrote: > From: Lee Jones > Date: Sat, 3 Nov 2012 23:02:30 +0100 > > > Instead of issuing (0) statements when !CONFIG_SYSFS which will cause > > 'warning: ', we'll use inline statements instead. This will effectively > > do the same thing, but suppress any unnecessary warnings. > > > > Cc: Stephen Hemminger > > Cc: bridge@lists.linux-foundation.org > > Cc: netdev@vger.kernel.org > > Signed-off-by: Lee Jones > > Applied, but please use more informative subject lines. > > You should prefix your subject line after [PATCH ...] with > the name of the subsystem you are touching, a ": " then > the headline description. > > So here you would have used "bridge: " and that's what I added when I > commited this patch. Yes, of course I should have done, and usually do. This was an oversight, sorry about that. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog