From: Stephen Hemminger <stephen@networkplumber.org>
To: Vlad Yasevich <vyasevic@redhat.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
mst@redhat.com
Subject: Re: [Bridge] [PATCHv2 net-next 2/2] bridge: Add a flag to control unicast packet flood.
Date: Mon, 29 Apr 2013 16:43:50 -0700 [thread overview]
Message-ID: <20130429164350.11eaaab1@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1367256945-25923-3-git-send-email-vyasevic@redhat.com>
On Mon, 29 Apr 2013 13:35:45 -0400
Vlad Yasevich <vyasevic@redhat.com> wrote:
> Add a flag to control flood of unicast traffic. By default, flood is
> on and the bridge will flood unicast traffic if it doesn't know
> the destination. When the flag is turned off, unicast traffic
> without an FDB will not be forwarded to the specified port.
>
> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
This a good idea and thank you for doing it. I like that the flag is expressed
as a positive value (rather than an inverse value like no-flood).
The name BR_UNICAST_FLOOD is too long, just use BR_FLOOD and keep the code
shorter.
This doesn't apply against current net-next (same problem as first patch).
Also, I am not a fan of having lots of boolean flag variables in normal
code paths. It ends up reading like PASCAL code. But probably unavoidable in this case.
next prev parent reply other threads:[~2013-04-29 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 17:35 [Bridge] [PATCHv2 net-next 0/2] Add two new flags to bridge Vlad Yasevich
2013-04-29 17:35 ` [Bridge] [PATCHv2 net-next 1/2] bridge: Add flag to control mac learning Vlad Yasevich
2013-04-29 17:55 ` Michael S. Tsirkin
2013-04-29 23:29 ` Stephen Hemminger
2013-04-29 17:35 ` [Bridge] [PATCHv2 net-next 2/2] bridge: Add a flag to control unicast packet flood Vlad Yasevich
2013-04-29 23:43 ` Stephen Hemminger [this message]
2013-04-30 14:02 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130429164350.11eaaab1@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox