From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 23 May 2013 12:56:00 +0200 From: Pablo Neira Ayuso Message-ID: <20130523105600.GA22553@localhost> References: <5195E53A.4060406@asianux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5195E53A.4060406@asianux.com> Subject: Re: [Bridge] [PATCH] bridge: netfilter: using strlcpy() instead of strncpy() List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Gang Cc: coreteam@netfilter.org, netdev , bridge@lists.linux-foundation.org, David Miller , stephen@networkplumber.org, netfilter@vger.kernel.org, bart.de.schuymer@pandora.be, netfilter-devel@vger.kernel.org, kaber@trash.net On Fri, May 17, 2013 at 04:07:22PM +0800, Chen Gang wrote: > > 'name' has already set all zero when it is defined, so not need let > strncpy() to pad it again. > > 'name' is a string, better always let is NUL terminated, so use > strlcpy() instead of strncpy(). Applied, thanks.