From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 30 May 2014 17:46:08 -0700 (PDT) Message-Id: <20140530.174608.587404162482133282.davem@davemloft.net> From: David Miller In-Reply-To: <53884CC6.2000000@davidnewall.com> References: <53815623.8020506@davidnewall.com> <20140529.153424.1310751217059624351.davem@davemloft.net> <53884CC6.2000000@davidnewall.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] Revert 462fb2af9788a82a534f8184abfde31574e1cfa0 (bridge : Sanitize skb before it enters the IP stack) List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: davidn@davidnewall.com Cc: bdschuym@pandora.be, netdev@vger.kernel.org, vyasevich@gmail.com, bridge@lists.linux-foundation.org, fw@strlen.de, stephen@networkplumber.org, bsd@redhat.com, netfilter-devel@vger.kernel.org From: David Newall Date: Fri, 30 May 2014 18:47:58 +0930 > On 30/05/14 08:04, David Miller wrote: >> You really need to check the return value as this can perform >> allocations, >> GFP_ATOMIC ones in fact. >> >> Also, why are we not bumping the statistics any more? I didn't see a >> discussion of that in this thread. > > I was only restoring the code as it was before the commit. Maybe > this, (instead of the previous patch of br_netfilter.c,) to keep the > (added) check on pskb_may_pull's return value and incremented > statistics? I don't see why you don't simply keep br_parse_ip_options() around and adjust it as you need, you're just mostly duplicating it's contents into br_nf_pre_routing().