From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Linus =?utf-8?Q?L=C3=BCssing?= Message-ID: <20141102153733.GA23084@odroid> References: <1411342364-4791-1-git-send-email-linus.luessing@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1411342364-4791-1-git-send-email-linus.luessing@web.de> Subject: Re: [Bridge] [PATCH] bridge: fix netfilter/NF_BR_LOCAL_OUT for own, locally generated queries List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 02 Nov 2014 15:45:07 -0000 To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, "David S. Miller" , Herbert Xu On Mon, Sep 22, 2014 at 01:32:44AM +0200, Linus Lüssing wrote: > Ebtables on the OUTPUT chain (NF_BR_LOCAL_OUT) would not work as expected > for both locally generated IGMP and MLD queries. The IP header specific > filter options are off by 14 Bytes for netfilter (actual output on > interfaces is fine). > > NF_HOOK() expects the skb->data to point to the IP header, not the > ethernet one (while dev_queue_xmit() does not). Luckily there is an > br_dev_queue_push_xmit() helper function already - let's just use that. bump