bridge.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Imre Palik <imrep.amz@gmail.com>
Cc: imrep@amazon.de, netdev@vger.kernel.org,
	bridge@lists.linux-foundation.org,
	Florian Westphal <fw@strlen.de>,
	linux-kernel@vger.kernel.org, aliguori@amazon.com,
	David Miller <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH] bridge: make it possible for packets to traverse the bridge withour hitting netfilter
Date: Fri, 13 Feb 2015 20:03:30 +0100	[thread overview]
Message-ID: <20150213190330.GD15141@breakpoint.cc> (raw)
In-Reply-To: <54DE3851.7000206@gmail.com>

Imre Palik <imrep.amz@gmail.com> wrote:
> The trouble is that there are some bridges (with low traffic) where I need netfilter, and some other bridges (carrying lots of traffic), where I don't.  Being able to set things up on a per bridge basis is a powerful thing.
> 
> I only implemented the global switch because the iptables and arptables support also have one.  If this is what bugs people here, I can remove it, and resubmit.

I see.  But I agree with David, accepting such patch would pave way
for all kinds of ugly hacks.

It seems that technically the best solution would be to allow attaching
filter rules to devices, but alas, netfilter doesn't support that.

Alternatively, you patch *might* be ok iff you can get rid of the extra
userspace-visible configuration knobs, we already have way too many of
these.

You'll also have to figure out how to avoid any run-time dependency on
br_netfilter module from the bridge core.

If you can do this, you might be able to get similar effect as your patch
by replacing

NF_HOOK with NF_HOOK_COND(..., !(br->flags & NO_NETFILTER))

or something like this.

I don't know how invasive this would be, though.

  reply	other threads:[~2015-02-13 19:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10  9:32 [Bridge] [PATCH] bridge: make it possible for packets to traverse the bridge withour hitting netfilter Imre Palik
2015-02-11 22:29 ` David Miller
2015-02-13 16:08   ` Imre Palik
2015-02-13 16:37     ` Florian Westphal
2015-02-13 17:45       ` Imre Palik
2015-02-13 19:03         ` Florian Westphal [this message]
2015-02-23 15:24           ` Imre Palik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150213190330.GD15141@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=aliguori@amazon.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=imrep.amz@gmail.com \
    --cc=imrep@amazon.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).