Ethernet Bridge development
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: cascardo@redhat.com
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
	bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Rik.Theys@esat.kuleuven.be
Subject: Re: [Bridge] [PATCH] bridge: fix parsing of MLDv2 reports
Date: Fri, 22 May 2015 15:09:03 -0400 (EDT)	[thread overview]
Message-ID: <20150522.150903.570785706419447424.davem@davemloft.net> (raw)
In-Reply-To: <1432307939-19640-1-git-send-email-cascardo@redhat.com>

From: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Date: Fri, 22 May 2015 12:18:59 -0300

> When more than a multicast address is present in a MLDv2 report, all but
> the first address is ignored, because the code breaks out of the loop if
> there has not been an error adding that address.
> 
> This has caused failures when two guests connected through the bridge
> tried to communicate using IPv6. Neighbor discoveries would not be
> transmitted to the other guest when both used a link-local address and a
> static address.
> 
> This only happens when there is a MLDv2 querier in the network.
> 
> The fix will only break out of the loop when there is a failure adding a
> multicast address.
 ...
> Reported-by: Rik Theys <Rik.Theys@esat.kuleuven.be>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
> Tested-by: Rik Theys <Rik.Theys@esat.kuleuven.be>

Applied and queued up for -stable, thanks.

      parent reply	other threads:[~2015-05-22 19:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 15:18 [Bridge] [PATCH] bridge: fix parsing of MLDv2 reports Thadeu Lima de Souza Cascardo
2015-05-22 16:37 ` Cong Wang
2015-05-22 19:09 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150522.150903.570785706419447424.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Rik.Theys@esat.kuleuven.be \
    --cc=bridge@lists.linux-foundation.org \
    --cc=cascardo@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox