bridge.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [Bridge] [PATCH net-next] bridge: mcast: fix br_multicast_dev_del warn when igmp snooping is not defined
       [not found] <201507210410.H5dNw6Lx%fengguang.wu@intel.com>
@ 2015-07-20 21:03 ` Nikolay Aleksandrov
  2015-07-20 23:20   ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Nikolay Aleksandrov @ 2015-07-20 21:03 UTC (permalink / raw)
  To: netdev; +Cc: Nikolay Aleksandrov, Nikolay Aleksandrov, bridge, davem

Fix:
net/bridge/br_if.c: In function 'br_dev_delete':
>> net/bridge/br_if.c:284:2: error: implicit declaration of function
>> 'br_multicast_dev_del' [-Werror=implicit-function-declaration]
     br_multicast_dev_del(br);
     ^
   cc1: some warnings being treated as errors

when igmp snooping is not defined.

Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
---
Apologies for the mess.

 net/bridge/br_private.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 2bada2279721..3ad1290528af 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -566,6 +566,10 @@ static inline void br_multicast_stop(struct net_bridge *br)
 {
 }
 
+static inline void br_multicast_dev_del(struct net_bridge *br)
+{
+}
+
 static inline void br_multicast_deliver(struct net_bridge_mdb_entry *mdst,
 					struct sk_buff *skb)
 {
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Bridge] [PATCH net-next] bridge: mcast: fix br_multicast_dev_del warn when igmp snooping is not defined
  2015-07-20 21:03 ` [Bridge] [PATCH net-next] bridge: mcast: fix br_multicast_dev_del warn when igmp snooping is not defined Nikolay Aleksandrov
@ 2015-07-20 23:20   ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-07-20 23:20 UTC (permalink / raw)
  To: razor; +Cc: netdev, bridge, nikolay

From: Nikolay Aleksandrov <razor@blackwall.org>
Date: Mon, 20 Jul 2015 23:03:45 +0200

> Fix:
> net/bridge/br_if.c: In function 'br_dev_delete':
>>> net/bridge/br_if.c:284:2: error: implicit declaration of function
>>> 'br_multicast_dev_del' [-Werror=implicit-function-declaration]
>      br_multicast_dev_del(br);
>      ^
>    cc1: some warnings being treated as errors
> 
> when igmp snooping is not defined.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
> Apologies for the mess.

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-20 23:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <201507210410.H5dNw6Lx%fengguang.wu@intel.com>
2015-07-20 21:03 ` [Bridge] [PATCH net-next] bridge: mcast: fix br_multicast_dev_del warn when igmp snooping is not defined Nikolay Aleksandrov
2015-07-20 23:20   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).