From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 24 Jun 2016 10:57:52 +0200 From: Pablo Neira Ayuso Message-ID: <20160624085752.GB1939@salvia> References: <20160623173659.GA3474@salvia> <1466708400.1847.15.camel@perches.com> <20160624085128.GA1939@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20160624085128.GA1939@salvia> Subject: Re: [Bridge] [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joe Perches Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Patrick McHardy , coreteam@netfilter.org, netfilter-devel@vger.kernel.org, Jozsef Kadlecsik , "David S. Miller" On Fri, Jun 24, 2016 at 10:51:28AM +0200, Pablo Neira Ayuso wrote: > On Thu, Jun 23, 2016 at 12:00:00PM -0700, Joe Perches wrote: > > On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote: > > > On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > > > >=20 > > > > There is code duplication of a masked ethernet address comparison h= ere > > > > so make it a separate function instead. > > > >=20 > > > > Miscellanea: > > > >=20 > > > > o Neaten alignment of FWINV macro uses to make it clearer for the r= eader > > > Applied, thanks. > > >=20 > > > >=20 > > > > Signed-off-by: Joe Perches > > > > --- > > > >=20 > > > > This masked_ether_addr_equal function could go into etherdevice.h, > > > > but I don't see another use like it in kernel code.=A0=A0Is there o= ne? > > > > > > This is specific of iptables, not even nftables would use this. So I > > > would keep this in the iptables tree. > >=20 > > Did you see the other patch that adds a generic > > ether_addr_equal_masked() and uses it in a few > > more files? >=20 > You mean this one: >=20 > http://patchwork.ozlabs.org/patch/636208/ >=20 > OK, so I'll toss the previous and will take this one instead. >=20 > As I said my opinion is that ether_addr_equal_masked() is only > required by netfilter, but thinking it well I don't really mind in > what header this function is placed given that these are our internal > headers. git am reports patch I get from patchwork is corrupt at line 37. Tried a couple of tricks to fix it but this didn't work. Would you mind resubmitting this patch? Sorry for the inconvenience.