From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GglY3ElDZIlvARrS7AlrZyPRQ6fXQeEjuxsHxyO3ZT0=; b=QIW7Hly05MRe7T3LUtUhI0V6qMAh+D3gHYmhNEdTUJvLr1cN4ikttzzcIEezankFto jPSyFKssb7NA7VcbJWUAiJ5xPe+Zk5KVW3pLRL4e0aSiun9SKy0YZ9jPiTJs0uR+4l7u 6ORy+zGZNtZJfu+zqc2+hCaDVTYN0m1roklqgmc924Xo02F/gHRzGpsm4gP2DJqhnYEO svq+aGgspqj+8dINMiLHinc8JI7feMnrWbNbW4c4qiqnNGlgw3ISel12KWbSXB3e/d+T 6ti2MDlAjDs//uiGC2a0WqkefpI/1hxjxtc/vKbziJVQvZeezYZBlRCcM+XuO8VAJGhg jilg== Date: Sat, 1 Apr 2017 16:48:21 -0700 From: Stephen Hemminger Message-ID: <20170401164821.036f1b41@plumbers-lap.home.lan> In-Reply-To: <20170328190516.GA19531@singhal-Inspiron-5558> References: <20170328190516.GA19531@singhal-Inspiron-5558> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v2] net: Remove unnecessary cast on void pointer List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: simran singhal Cc: gregkh@linuxfoundation.org, Hideaki YOSHIFUJI , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, James Morris , outreachy-kernel@googlegroups.com, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, kadlec@blackhole.kfki.hu, Patrick McHardy , Alexey Kuznetsov , davem@davemloft.net, pablo@netfilter.org On Wed, 29 Mar 2017 00:35:16 +0530 simran singhal wrote: > The following Coccinelle script was used to detect this: > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T*)x)->f > | > > - (T*) > e > ) > > Unnecessary parantheses are also remove. > > Signed-off-by: simran singhal Looks good Reviewed-by: Stephen Hemminger