From: Andrew Lunn <andrew@lunn.ch>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next v2 3/3] net: bridge: export supported boolopts
Date: Sat, 24 Nov 2018 17:16:47 +0100 [thread overview]
Message-ID: <20181124161647.GB24681@lunn.ch> (raw)
In-Reply-To: <20181124023422.13908-4-nikolay@cumulusnetworks.com>
On Sat, Nov 24, 2018 at 04:34:22AM +0200, Nikolay Aleksandrov wrote:
> Now that we have at least one bool option, we can export all of the
> supported bool options via optmask when dumping them.
>
Hi Nik
That answers my question then...
I'm assuming this means there is no easy way to generate a bitmask of
0? So you waited until there was at least one bit.
(1 << 2) - 1 = 3
(1 << 1) - 1 = 1
(1 << 0) - 1 = 0
So does
GENMASK((BR_BOOLOPT_MAX - 1), 0);
really not do the right thing when BR_BOOLOPT_MAX = 1?
Andrew
next prev parent reply other threads:[~2018-11-24 16:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 2:34 [Bridge] [PATCH net-next v2 0/3] net: bridge: add an option to disabe linklocal learning Nikolay Aleksandrov
2018-11-24 2:34 ` [Bridge] [PATCH net-next v2 1/3] net: bridge: add support for user-controlled bool options Nikolay Aleksandrov
2018-11-24 16:10 ` Andrew Lunn
2018-11-24 16:18 ` nikolay
2018-11-24 16:25 ` Andrew Lunn
2018-11-24 16:46 ` nikolay
2018-11-25 8:12 ` Nikolay Aleksandrov
2018-11-26 17:39 ` Stephen Hemminger
2018-11-26 17:41 ` Nikolay Aleksandrov
2018-11-25 15:45 ` Andrew Lunn
2018-11-24 2:34 ` [Bridge] [PATCH net-next v2 2/3] net: bridge: add no_linklocal_learn bool option Nikolay Aleksandrov
2018-11-24 16:27 ` Andrew Lunn
2018-11-24 2:34 ` [Bridge] [PATCH net-next v2 3/3] net: bridge: export supported boolopts Nikolay Aleksandrov
2018-11-24 16:16 ` Andrew Lunn [this message]
2018-11-24 16:20 ` nikolay
2018-11-24 16:26 ` Andrew Lunn
2018-11-27 23:04 ` [Bridge] [PATCH net-next v2 0/3] net: bridge: add an option to disabe linklocal learning David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181124161647.GB24681@lunn.ch \
--to=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox