From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 03 Feb 2019 11:40:05 -0800 (PST) Message-Id: <20190203.114005.1068563409105929462.davem@davemloft.net> From: David Miller In-Reply-To: <20190202042055.27202-1-f.fainelli@gmail.com> References: <20190202042055.27202-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next] net: Fix ip_mc_{dec, inc}_group allocation context List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: f.fainelli@gmail.com Cc: andrew@lunn.ch, sbrivio@redhat.com, nikolay@cumulusnetworks.com, netdev@vger.kernel.org, roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org, liuhangbin@gmail.com, kuznet@ms2.inr.ac.ru From: Florian Fainelli Date: Fri, 1 Feb 2019 20:20:52 -0800 > After 4effd28c1245 ("bridge: join all-snoopers multicast address"), I > started seeing the following sleep in atomic warnings: ... > while toggling the bridge's multicast_snooping attribute dynamically. > > Pass a gfp_t down to igmpv3_add_delrec(), introduce > __igmp_group_dropped() and introduce __ip_mc_dec_group() to take a gfp_t > argument. > > Similarly introduce ____ip_mc_inc_group() and __ip_mc_inc_group() to > allow caller to specify gfp_t. > > IPv6 part of the patch appears fine. > > Fixes: 4effd28c1245 ("bridge: join all-snoopers multicast address") > Signed-off-by: Florian Fainelli Applied. Maybe you could submit a quick test case since you had a reproducer?