From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 23 Jul 2020 13:44:58 +0200 From: 'Christoph Hellwig' Message-ID: <20200723114458.GA31363@lst.de> References: <20200723060908.50081-1-hch@lst.de> <20200723060908.50081-14-hch@lst.de> <621e193e4af74d8198ed87d6a9ce8260@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <621e193e4af74d8198ed87d6a9ce8260@AcuMS.aculab.com> Subject: Re: [Bridge] [PATCH 13/26] bpfilter: switch bpfilter_ip_set_sockopt to sockptr_t List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Laight Cc: Alexei Starovoitov , "linux-sctp@vger.kernel.org" , 'Christoph Hellwig' , "linux-s390@vger.kernel.org" , "rds-devel@oss.oracle.com" , Daniel Borkmann , "dccp@vger.kernel.org" , "bridge@lists.linux-foundation.org" , "linux-afs@lists.infradead.org" , "lvs-devel@vger.kernel.org" , "coreteam@netfilter.org" , "mptcp@lists.01.org" , Alexey Kuznetsov , "linux-can@vger.kernel.org" , Jakub Kicinski , "linux-hams@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "linux-x25@vger.kernel.org" , Eric Dumazet , Hideaki YOSHIFUJI , "netdev@vger.kernel.org" , "linux-decnet-user@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-bluetooth@vger.kernel.org" , "netfilter-devel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-wpan@vger.kernel.org" , "David S. Miller" On Thu, Jul 23, 2020 at 11:16:16AM +0000, David Laight wrote: > From: Christoph Hellwig > > Sent: 23 July 2020 07:09 > > > > This is mostly to prepare for cleaning up the callers, as bpfilter by > > design can't handle kernel pointers. > > You've failed to fix the sense of the above... The sense still is correct.