From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602654174; bh=w10HAUvHzI4K2dPPA6eBw0IIFtp11qCCa0wUzKaUmD8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cKsoRdZk0/7P9W5KQIcB78oxj7gSK1YWQM+hrVcStVlKqV5euxdawGaIKjsJO+YUU /usInNdGonQCzHNv/4cuzYg3D1kAHdZbtEGHplDqaWK5j6M3yEug5qW6hLhVGcPu6C Ur12VOGAV45LDfAlhlt9kErfzTLPyFZ2XWjKnbEc= Date: Wed, 14 Oct 2020 08:42:50 +0300 From: Leon Romanovsky Message-ID: <20201014054250.GB6305@unreal> References: <20201013173951.25677bcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201013173951.25677bcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Subject: Re: [Bridge] [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jakub Kicinski Cc: Andrew Lunn , Linux USB Mailing List , Steffen Klassert , Florian Fainelli , Herbert Xu , Sergey Matyukevich , linux-rdma@vger.kernel.org, bridge@lists.linux-foundation.org, Pravin B Shelar , Nikolay Aleksandrov , Roopa Prabhu , Alexey Kuznetsov , Vivien Didelot , Igor Mitsyanko , Kalle Valo , Hideaki YOSHIFUJI , "netdev@vger.kernel.org" , Oliver Neukum , linux-wireless , Johannes Berg , Vladimir Oltean , David Miller , =?iso-8859-1?Q?Bj=F8rn?= Mork , Heiner Kallweit On Tue, Oct 13, 2020 at 05:39:51PM -0700, Jakub Kicinski wrote: > On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote: > > In several places the same code is used to populate rtnl_link_stats64 > > fields with data from pcpu_sw_netstats. Therefore factor out this code > > to a new function dev_fetch_sw_netstats(). > > > > v2: > > - constify argument netstats > > - don't ignore netstats being NULL or an ERRPTR > > - switch to EXPORT_SYMBOL_GPL > > Applied, thank you! Jakub, Is it possible to make sure that changelogs are not part of the commit messages? We don't store previous revisions in the git repo, so it doesn't give too much to anyone who is looking on git log later. The lore link to the patch is more than enough. 44fa32f008ab ("net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats") Thanks